Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1394)

Unified Diff: Source/devtools/front_end/toolbox/ResponsiveDesignView.js

Issue 555433002: [DevTools] Add "never show" link to emulation warning. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/sdk/OverridesSupport.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/toolbox/ResponsiveDesignView.js
diff --git a/Source/devtools/front_end/toolbox/ResponsiveDesignView.js b/Source/devtools/front_end/toolbox/ResponsiveDesignView.js
index 96c4a50ee8f06744c159e5680dd0d6f0dbe1cd99..d3534fc20ed288cb8176a5e56a9c89d1ffcab0fe 100644
--- a/Source/devtools/front_end/toolbox/ResponsiveDesignView.js
+++ b/Source/devtools/front_end/toolbox/ResponsiveDesignView.js
@@ -33,9 +33,13 @@ WebInspector.ResponsiveDesignView = function(inspectedPagePlaceholder)
this._warningMessage = this._canvasContainer.element.createChild("div", "responsive-design-warning hidden");
this._warningMessage.createChild("div", "warning-icon-small");
this._warningMessage.createChild("span");
+ var warningDisableButton = this._warningMessage.createChild("div", "disable-warning");
+ warningDisableButton.textContent = WebInspector.UIString("Never show");
+ warningDisableButton.addEventListener("click", this._disableOverridesWarnings.bind(this), false);
var warningCloseButton = this._warningMessage.createChild("div", "close-button");
warningCloseButton.addEventListener("click", WebInspector.overridesSupport.clearWarningMessage.bind(WebInspector.overridesSupport), false);
WebInspector.overridesSupport.addEventListener(WebInspector.OverridesSupport.Events.OverridesWarningUpdated, this._overridesWarningUpdated, this);
+ WebInspector.settings.disableOverridesWarning.addChangeListener(this._overridesWarningUpdated, this);
this._slidersContainer = this._canvasContainer.element.createChild("div", "vbox responsive-design-sliders-container");
var hbox = this._slidersContainer.createChild("div", "hbox flex-auto");
@@ -684,15 +688,21 @@ WebInspector.ResponsiveDesignView.prototype = {
_overridesWarningUpdated: function()
{
- var message = WebInspector.overridesSupport.warningMessage();
- if (this._warningMessage.querySelector("span").textContent === message)
+ var message = WebInspector.settings.disableOverridesWarning.get() ? "" : WebInspector.overridesSupport.warningMessage();
+ if (this._warning === message)
return;
+ this._warning = message;
this._warningMessage.classList.toggle("hidden", !message);
this._warningMessage.querySelector("span").textContent = message;
this._invalidateCache();
this.onResize();
},
+ _disableOverridesWarnings: function()
+ {
+ WebInspector.settings.disableOverridesWarning.set(true);
+ },
+
_showEmulationInDrawer: function()
{
WebInspector.Revealer.reveal(WebInspector.overridesSupport);
« no previous file with comments | « Source/devtools/front_end/sdk/OverridesSupport.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698