Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(838)

Issue 555253004: Revert of [Android] Temporarily suppress RTL start&end check error. (Closed)

Created:
6 years, 3 months ago by Kibeom Kim (inactive)
Modified:
6 years, 3 months ago
Reviewers:
Ted C, gone, newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, gone, aurimas (slooooooooow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Temporarily suppress RTL start&end check error. (patchset #1 id:1 of https://codereview.chromium.org/445753002/) Reason for revert: Android SDK fixed the issue, so we can convert back from warning to error. Original issue's description: > [Android] Temporarily suppress RTL start&end check error. > > The newest Android SDK had start&end attributes in non -v17 resources. > Temporarily change the checking script from error to warning so that > people can continue to work before it is fixed. This should be > reverted once the issue is addressed > > BUG=None > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287711 TBR=newt@chromium.org,tedchoc@chromium.org,dfalcantara@chromium.org BUG=None Committed: https://crrev.com/992e0f97595ddf295f15550fcb3e9e5947c90108 Cr-Commit-Position: refs/heads/master@{#294038}

Patch Set 1 #

Patch Set 2 : patch set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M build/android/gyp/generate_v14_compatible_resources.py View 1 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Kibeom Kim (inactive)
Created Revert of [Android] Temporarily suppress RTL start&end check error.
6 years, 3 months ago (2014-09-09 21:36:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/555253004/40001
6 years, 3 months ago (2014-09-09 21:42:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kkimlabs@chromium.org/555253004/40001
6 years, 3 months ago (2014-09-09 23:25:09 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 66c4e4305921f5580c7c77450f54b09f236f1364
6 years, 3 months ago (2014-09-09 23:48:59 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:56:36 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/992e0f97595ddf295f15550fcb3e9e5947c90108
Cr-Commit-Position: refs/heads/master@{#294038}

Powered by Google App Engine
This is Rietveld 408576698