Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: build/android/gyp/generate_v14_compatible_resources.py

Issue 555253004: Revert of [Android] Temporarily suppress RTL start&end check error. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: patch set 1 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/generate_v14_compatible_resources.py
diff --git a/build/android/gyp/generate_v14_compatible_resources.py b/build/android/gyp/generate_v14_compatible_resources.py
index 2f1d81212eac7130bd32f56561b8dc9764ed337e..1961622b7afb26ffb84af9c1999233d1e77f487a 100755
--- a/build/android/gyp/generate_v14_compatible_resources.py
+++ b/build/android/gyp/generate_v14_compatible_resources.py
@@ -226,18 +226,18 @@ def VerifyV14ResourcesInDir(input_dir, resource_type):
don't use attributes that cause crashes on certain devices. Print an error if
they have."""
for input_filename in build_utils.FindInDirectory(input_dir, '*.xml'):
- warning_message = ('warning : ' + input_filename + ' has an RTL attribute, '
- 'i.e., attribute that has "start" or "end" in its name.'
- ' Pre-v17 resources should not include it because it '
- 'can cause crashes on certain devices. Please refer to '
- 'http://crbug.com/243952 for the details.')
+ exception_message = ('error : ' + input_filename + ' has an RTL attribute, '
+ 'i.e., attribute that has "start" or "end" in its name.'
+ ' Pre-v17 resources should not include it because it '
+ 'can cause crashes on certain devices. Please refer to '
+ 'http://crbug.com/243952 for the details.')
dom = minidom.parse(input_filename)
if resource_type in ('layout', 'xml'):
if GenerateV14LayoutResourceDom(dom, input_filename, False):
- print warning_message
+ raise Exception(exception_message)
elif resource_type == 'values':
if GenerateV14StyleResourceDom(dom, input_filename, False):
- print warning_message
+ raise Exception(exception_message)
def AssertNoDeprecatedAttributesInDir(input_dir, resource_type):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698