Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: Source/bindings/core/v8/V8Binding.cpp

Issue 555133003: Use ExceptionState to throw exceptions when converting arrays (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/V8Binding.cpp
diff --git a/Source/bindings/core/v8/V8Binding.cpp b/Source/bindings/core/v8/V8Binding.cpp
index 54eb709dfd0ed28de7083e9d7f9b7e25b5599d18..52ad09915c60a35fbdb19311618d3baee4f5d084 100644
--- a/Source/bindings/core/v8/V8Binding.cpp
+++ b/Source/bindings/core/v8/V8Binding.cpp
@@ -934,7 +934,9 @@ void GetDevToolsFunctionInfo(v8::Handle<v8::Function> function, v8::Isolate* iso
scriptId = originalFunction->ScriptId();
v8::ScriptOrigin origin = originalFunction->GetScriptOrigin();
if (!origin.ResourceName().IsEmpty()) {
- resourceName = NativeValueTraits<String>::nativeValue(origin.ResourceName(), isolate);
+ V8StringResource<> stringResource(origin.ResourceName());
Jens Widell 2014/09/11 13:22:31 It feels like maybe we could do something better h
+ stringResource.prepare();
+ resourceName = stringResource;
lineNumber = originalFunction->GetScriptLineNumber() + 1;
}
if (resourceName.isEmpty()) {

Powered by Google App Engine
This is Rietveld 408576698