Use ExceptionState to throw exceptions when converting arrays

Source/bindings/core/v8/V8Binding.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 916 matching lines @@
 {
     return m_scriptState->isolate();
 }
 
 void GetDevToolsFunctionInfo(v8::Handle<v8::Function> function, v8::Isolate* isolate, int& scriptId, String& resourceName, int& lineNumber)
 {
     v8::Handle<v8::Function> originalFunction = getBoundFunction(function);
     scriptId = originalFunction->ScriptId();
     v8::ScriptOrigin origin = originalFunction->GetScriptOrigin();
     if (!origin.ResourceName().IsEmpty()) {
-        resourceName = NativeValueTraits<String>::nativeValue(origin.ResourceName(), isolate);
+        V8StringResource<> stringResource(origin.ResourceName());

[Jens Widell, 2014/09/11 13:22:31]

It feels like maybe we could do something better here, especially given that
ResourceName(), if not empty, ought to be a string, and thus not really need
conversion logic at all. Or can the resource name be something other than a
string?

+        stringResource.prepare();
+        resourceName = stringResource;
         lineNumber = originalFunction->GetScriptLineNumber() + 1;
     }
     if (resourceName.isEmpty()) {
         resourceName = "undefined";
         lineNumber = 1;
     }
 }
 
 PassRefPtr<TraceEvent::ConvertableToTraceFormat> devToolsTraceEventData(ExecutionContext* context, v8::Handle<v8::Function> function, v8::Isolate* isolate)
 {
@@ skipping 14 matching lines @@
 
 v8::Local<v8::Value> v8IteratorResult(v8::Isolate* isolate, v8::Handle<v8::Value> value)
 {
     v8::Local<v8::Object> result = v8::Object::New(isolate);
     result->Set(v8String(isolate, "value"), value);
     result->Set(v8String(isolate, "done"), v8Boolean(false, isolate));
     return result;
 }
 
 } // namespace blink