Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 554893004: IDL: Add more test cases to idl-dictionary-unittest.html (Closed)

Created:
6 years, 3 months ago by bashi
Modified:
6 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, Inactive, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

IDL: Add more test cases to idl-dictionary-unittest.html Add DictionaryHelper::getWithUndefinedOrNullCheck() to fix a bug that newly added tests found. When IDL dictionary member is undefined or null, the member should be treated as 'not present' and default values should be used when specified. Since DictionaryHelper::get() converts null/undefined into a valid value, we can't use DictionaryHelper::get() in IDL dictionary implementation directly. BUG=321462 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -67 lines) Patch
M LayoutTests/fast/dom/idl-dictionary-unittest.html View 1 chunk +58 lines, -23 lines 0 comments Download
M LayoutTests/fast/dom/idl-dictionary-unittest-expected.txt View 1 chunk +37 lines, -10 lines 0 comments Download
M Source/bindings/core/v8/Dictionary.h View 2 chunks +9 lines, -1 line 0 comments Download
M Source/bindings/core/v8/DictionaryHelperForCore.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/bindings/templates/dictionary_v8.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestDictionary.cpp View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/core/testing/DictionaryTest.h View 2 chunks +15 lines, -5 lines 0 comments Download
M Source/core/testing/DictionaryTest.cpp View 2 chunks +44 lines, -11 lines 0 comments Download
M Source/core/testing/InternalDictionary.idl View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bashi
Haraken-san, PTAL? This is obsoleting https://codereview.chromium.org/508073002/. I'm working on refactoring DictionaryHelper, but it takes some ...
6 years, 3 months ago (2014-09-09 04:01:25 UTC) #2
haraken
LGTM.
6 years, 3 months ago (2014-09-09 04:06:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bashi@chromium.org/554893004/1
6 years, 3 months ago (2014-09-09 04:18:08 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 05:02:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181604

Powered by Google App Engine
This is Rietveld 408576698