Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: Source/bindings/templates/dictionary_v8.cpp

Issue 554893004: IDL: Add more test cases to idl-dictionary-unittest.html (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/dictionary_v8.cpp
diff --git a/Source/bindings/templates/dictionary_v8.cpp b/Source/bindings/templates/dictionary_v8.cpp
index 2b3c32e728c403ff49c79d3063e910323e1fe822..82c6e9accf1d60a42ae7ed24b8c2baf9d2235c02 100644
--- a/Source/bindings/templates/dictionary_v8.cpp
+++ b/Source/bindings/templates/dictionary_v8.cpp
@@ -21,7 +21,7 @@ namespace blink {
Dictionary dictionary(v8Value, isolate);
{% for member in members %}
{{member.cpp_type}} {{member.name}};
- if (DictionaryHelper::get(dictionary, "{{member.name}}", {{member.name}}))
+ if (DictionaryHelper::getWithUndefinedOrNullCheck(dictionary, "{{member.name}}", {{member.name}}))
impl->{{member.setter_name}}({{member.name}});
{% endfor %}
return impl;
« no previous file with comments | « Source/bindings/core/v8/DictionaryHelperForCore.cpp ('k') | Source/bindings/tests/results/V8TestDictionary.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698