Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 554893002: [WORK_IN_PROGRESS] PDF::Save() fix for out-of-process-pdf.

Created:
6 years, 3 months ago by lazyboy
Modified:
6 years, 3 months ago
Reviewers:
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, yusukes+watch_chromium.org, tzik, binji+watch_chromium.org, nasko+codewatch_chromium.org, jam, raymes+watch_chromium.org, teravest+watch_chromium.org, darin-cc_chromium.org, arv+watch_chromium.org, nfullagar1, piman+watch_chromium.org, chromium-apps-reviews_chromium.org, noelallen1, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[WORK_IN_PROGRESS] PDF::Save() fix for out-of-process-pdf. The changes in ppapi is temporary, for me to pass along the stream url, there should be a better way to do this, I just hacked it up to see if my *Helper* changes are correct. BUG=411765 Test=

Patch Set 1 #

Patch Set 2 : with print dialog fix (aura only) #

Patch Set 3 : remove unnecessary changes #

Patch Set 4 : better fix for constrained windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -86 lines) Patch
M chrome/browser/extensions/api/chrome_extensions_api_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/chrome_extensions_api_client.cc View 2 chunks +7 lines, -0 lines 0 comments Download
A chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.h View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
M chrome/browser/resources/pdf/background.js View 1 chunk +30 lines, -16 lines 0 comments Download
M chrome/browser/resources/pdf/manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 1 2 8 chunks +66 lines, -38 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac.mm View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M components/pdf/renderer/pepper_pdf_host.h View 1 chunk +2 lines, -1 line 0 comments Download
M components/pdf/renderer/pepper_pdf_host.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M components/pdf/renderer/ppb_pdf_impl.cc View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M extensions/browser/api/extensions_api_client.h View 3 chunks +6 lines, -0 lines 0 comments Download
M extensions/browser/api/extensions_api_client.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.h View 2 chunks +5 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc View 5 chunks +15 lines, -6 lines 0 comments Download
A extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest_delegate.h View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M pdf/instance.cc View 1 chunk +1 line, -1 line 0 comments Download
M pdf/out_of_process_instance.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M ppapi/c/private/ppb_pdf.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/cpp/private/pdf.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/cpp/private/pdf.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/pdf_resource.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/pdf_resource.cc View 1 chunk +9 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +2 lines, -1 line 0 comments Download
M ppapi/thunk/ppb_pdf_api.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/thunk/ppb_pdf_thunk.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698