Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: components/pdf/renderer/ppb_pdf_impl.cc

Issue 554893002: [WORK_IN_PROGRESS] PDF::Save() fix for out-of-process-pdf. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: better fix for constrained windows Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/pdf/renderer/pepper_pdf_host.cc ('k') | extensions/browser/api/extensions_api_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/pdf/renderer/ppb_pdf_impl.cc
diff --git a/components/pdf/renderer/ppb_pdf_impl.cc b/components/pdf/renderer/ppb_pdf_impl.cc
index 3667c47722f9d3d98121d1000564d3bc10d48c7f..d73b0a33e843fa1b1e4fef69fabe68e2e1c6078a 100644
--- a/components/pdf/renderer/ppb_pdf_impl.cc
+++ b/components/pdf/renderer/ppb_pdf_impl.cc
@@ -230,11 +230,17 @@ void HasUnsupportedFeature(PP_Instance instance_id) {
new PDFHostMsg_PDFHasUnsupportedFeature(render_view->GetRoutingID()));
}
-void SaveAs(PP_Instance instance_id) {
+void SaveAs(PP_Instance instance_id, PP_Var provided_url) {
content::PepperPluginInstance* instance =
content::PepperPluginInstance::Get(instance_id);
if (!instance)
return;
+ scoped_refptr<ppapi::StringVar> url_str(
+ ppapi::StringVar::FromPPVar(provided_url));
+ if (url_str.get())
+ printf("GOT url: %s\n", url_str->value().c_str());
+ else
+ printf("NO URL\n");
GURL url = instance->GetPluginURL();
content::RenderView* render_view = instance->GetRenderView();
« no previous file with comments | « components/pdf/renderer/pepper_pdf_host.cc ('k') | extensions/browser/api/extensions_api_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698