Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Issue 554693002: Include Pepper headers only if ENABLE_PLUGINS is defined (Closed)

Created:
6 years, 3 months ago by dnicoara
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Include Pepper headers only if ENABLE_PLUGINS is defined Follow-up to https://codereview.chromium.org/525513003 to fix includes of Pepper files when ENABLE_PLUGINS isn't defined (Ozone ECS builder). BUG=none TBR=markus@chromium.org NOTRY=true Committed: https://crrev.com/ab4353573415a4032e250ee301869e65e72016d4 Cr-Commit-Position: refs/heads/master@{#293760}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/zygote/zygote_main_linux.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dnicoara
markus@ for OWNERS thestig@ FYI
6 years, 3 months ago (2014-09-08 14:59:48 UTC) #2
dnicoara
TBR-ing since this is breaking the Ozone bot.
6 years, 3 months ago (2014-09-08 17:16:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/554693002/1
6 years, 3 months ago (2014-09-08 17:19:29 UTC) #5
Lei Zhang
lgtm
6 years, 3 months ago (2014-09-08 18:15:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dnicoara@chromium.org/554693002/1
6 years, 3 months ago (2014-09-08 18:27:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 03bb55eb304a2ff0763b0cb5f7334e80fc5c2c0c
6 years, 3 months ago (2014-09-08 18:42:30 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:47:20 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ab4353573415a4032e250ee301869e65e72016d4
Cr-Commit-Position: refs/heads/master@{#293760}

Powered by Google App Engine
This is Rietveld 408576698