Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 525513003: Cleanup: Put more plugin code behind the ENABLE_PLUGINS ifdef. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
palmer, jam
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Put more plugin code behind the ENABLE_PLUGINS ifdef. Committed: https://crrev.com/c4cac8f477f9c5317ff604b375175f07235b07b4 Cr-Commit-Position: refs/heads/master@{#293338}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix gn #

Patch Set 4 : rebase, fix gn for reals #

Total comments: 2

Patch Set 5 : address comment #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -43 lines) Patch
M chrome/common/chrome_content_client.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M content/browser/browser_main_loop.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M content/browser/download/download_browsertest.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/frame_host/debug_urls.cc View 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/loader/buffered_resource_handler.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/plugin_service_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/pepper/browser_ppapi_host_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 4 chunks +6 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 6 chunks +9 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 4 5 5 chunks +8 lines, -5 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 8 chunks +10 lines, -8 lines 0 comments Download
M content/common/BUILD.gn View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M content/common/pepper_file_util.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/pepper_plugin_list.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/common/pepper_renderer_instance_data.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/plugin_list.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/common/utility_messages.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/common/view_messages.h View 1 2 7 chunks +10 lines, -1 line 0 comments Download
M content/content_common.gypi View 1 chunk +10 lines, -0 lines 0 comments Download
M content/content_renderer.gypi View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/common/BUILD.gn View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M content/public/common/pepper_plugin_info.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/renderer_main.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/utility/utility_thread_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/utility/utility_thread_impl.cc View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Lei Zhang
6 years, 3 months ago (2014-09-02 21:56:55 UTC) #2
jam
lgtm https://codereview.chromium.org/525513003/diff/60001/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/525513003/diff/60001/content/renderer/render_thread_impl.cc#newcode1337 content/renderer/render_thread_impl.cc:1337: #if defined(ENABLE_PLUGINS) nit: put the ifdefs at the ...
6 years, 3 months ago (2014-09-03 17:37:06 UTC) #3
Lei Zhang
https://codereview.chromium.org/525513003/diff/60001/content/renderer/render_thread_impl.cc File content/renderer/render_thread_impl.cc (right): https://codereview.chromium.org/525513003/diff/60001/content/renderer/render_thread_impl.cc#newcode1337 content/renderer/render_thread_impl.cc:1337: #if defined(ENABLE_PLUGINS) On 2014/09/03 17:37:05, jam wrote: > nit: ...
6 years, 3 months ago (2014-09-04 00:30:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/525513003/100001
6 years, 3 months ago (2014-09-04 00:35:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/8583)
6 years, 3 months ago (2014-09-04 01:35:01 UTC) #8
Lei Zhang
+palmer for IPC
6 years, 3 months ago (2014-09-04 02:19:37 UTC) #10
palmer
Rubberstamp LGTM
6 years, 3 months ago (2014-09-04 18:44:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/525513003/100001
6 years, 3 months ago (2014-09-04 19:57:41 UTC) #13
commit-bot: I haz the power
Committed patchset #6 (id:100001) as c5ee8caf7e3a78c5e6dc95b36d695eea65b7dc8e
6 years, 3 months ago (2014-09-04 21:19:21 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:32:44 UTC) #15
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/c4cac8f477f9c5317ff604b375175f07235b07b4
Cr-Commit-Position: refs/heads/master@{#293338}

Powered by Google App Engine
This is Rietveld 408576698