[Athena] Simple pull to refresh implementation

content/browser/web_contents/web_contents_view_aura.cc

Index: content/browser/web_contents/web_contents_view_aura.cc
diff --git a/content/browser/web_contents/web_contents_view_aura.cc b/content/browser/web_contents/web_contents_view_aura.cc
index ecbe02ca04e5d4dd798d5a9a6599dbc6e03229c1..71aa746f4ed78a4fc602b3e5136360ce4421c4ab 100644
--- a/content/browser/web_contents/web_contents_view_aura.cc
+++ b/content/browser/web_contents/web_contents_view_aura.cc
@@ -1302,7 +1302,8 @@ bool WebContentsViewAura::OnOverscrollUpdate(float delta_x, float delta_y) {
 
 void WebContentsViewAura::OnOverscrollComplete(OverscrollMode mode) {
   UMA_HISTOGRAM_ENUMERATION("Overscroll.Completed", mode, OVERSCROLL_COUNT);
-  OverscrollUpdateForWebContentsDelegate(0);
+  if (web_contents_->GetDelegate() && IsScrollEndEffectEnabled())
+    web_contents_->GetDelegate()->OverscrollComplete();

[sadrul, 2014/09/11 04:33:14]

Since we send updates to the WebContentsDelegate only for vertical scrolls,
should we call this complete for vertical scrolls too (i.e. only when mode ==
NORTH || SOUTH)?

[pkotwicz, 2014/09/11 22:51:40]

I have changed the code to only send updates when a user is scrolling
vertically. Previously, we would call OverscrollUpdateForWebContentsDelegate(0)
when a user was scrolling horizontally as well

I should probably rename WebContentsDelegate::OverscrollComplete() to
WebContentsDelegate::VerticalOverscrollComplete() and
WebContentsDelegate::OverscrollUpdate() to
WebContentsDelegate::VerticalOverscrollUpdate() ?

   NavigationControllerImpl& controller = web_contents_->GetController();
   if (ShouldNavigateForward(controller, mode) ||
       ShouldNavigateBack(controller, mode)) {