[Athena] Simple pull to refresh implementation

content/browser/web_contents/web_contents_view_aura.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_view_aura.h"
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/metrics/histogram.h"
@@ skipping 1284 matching lines @@
     target->SetTransform(transform);
     UpdateOverscrollWindowBrightness(delta_x);
   }
 
   OverscrollUpdateForWebContentsDelegate(translate.y());
   return !translate.IsZero();
 }
 
 void WebContentsViewAura::OnOverscrollComplete(OverscrollMode mode) {
   UMA_HISTOGRAM_ENUMERATION("Overscroll.Completed", mode, OVERSCROLL_COUNT);
-  OverscrollUpdateForWebContentsDelegate(0);
+  if (web_contents_->GetDelegate() && IsScrollEndEffectEnabled())
+    web_contents_->GetDelegate()->OverscrollComplete();

[sadrul, 2014/09/11 04:33:14]

Since we send updates to the WebContentsDelegate only for vertical scrolls,
should we call this complete for vertical scrolls too (i.e. only when mode ==
NORTH || SOUTH)?

[pkotwicz, 2014/09/11 22:51:40]

I have changed the code to only send updates when a user is scrolling
vertically. Previously, we would call OverscrollUpdateForWebContentsDelegate(0)
when a user was scrolling horizontally as well

I should probably rename WebContentsDelegate::OverscrollComplete() to
WebContentsDelegate::VerticalOverscrollComplete() and
WebContentsDelegate::OverscrollUpdate() to
WebContentsDelegate::VerticalOverscrollUpdate() ?

   NavigationControllerImpl& controller = web_contents_->GetController();
   if (ShouldNavigateForward(controller, mode) ||
       ShouldNavigateBack(controller, mode)) {
     CompleteOverscrollNavigation(mode);
     return;
   }
 
   ResetOverscrollTransform();
 }
 
@@ skipping 301 matching lines @@
   if (visible) {
     if (!web_contents_->should_normally_be_visible())
       web_contents_->WasShown();
   } else {
     if (web_contents_->should_normally_be_visible())
       web_contents_->WasHidden();
   }
 }
 
 }  // namespace content