Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: chrome/browser/notifications/notification.cc

Issue 554213003: Request the icon of a Web Notification in the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removes now redundant code Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification.cc
diff --git a/chrome/browser/notifications/notification.cc b/chrome/browser/notifications/notification.cc
index bb926392b106fee080ee40d0582c31c2069a7394..33048e1b642abf7db3a712f4ee3489ed3b7daf7a 100644
--- a/chrome/browser/notifications/notification.cc
+++ b/chrome/browser/notifications/notification.cc
@@ -4,28 +4,6 @@
#include "chrome/browser/notifications/notification.h"
-Notification::Notification(const GURL& origin_url,
- const GURL& icon_url,
- const base::string16& title,
- const base::string16& body,
- blink::WebTextDirection dir,
- const base::string16& display_source,
- const base::string16& replace_id,
- NotificationDelegate* delegate)
- : message_center::Notification(message_center::NOTIFICATION_TYPE_SIMPLE,
- delegate->id(),
- title,
- body,
- gfx::Image(),
- display_source,
- message_center::NotifierId(origin_url),
- message_center::RichNotificationData(),
- delegate),
- origin_url_(origin_url),
- icon_url_(icon_url),
- replace_id_(replace_id),
- delegate_(delegate) {}
-
Notification::Notification(
message_center::NotificationType type,
const GURL& origin_url,
@@ -49,10 +27,7 @@ Notification::Notification(
delegate),
origin_url_(origin_url),
replace_id_(replace_id),
- delegate_(delegate) {
- // It's important to leave |icon_url_| empty with rich notifications enabled,
- // to prevent "Downloading" the data url and overwriting the existing |icon|.
-}
+ delegate_(delegate) {}
Notification::Notification(const GURL& origin_url,
const gfx::Image& icon,
@@ -78,7 +53,6 @@ Notification::Notification(const GURL& origin_url,
Notification::Notification(const Notification& notification)
: message_center::Notification(notification),
origin_url_(notification.origin_url()),
- icon_url_(notification.icon_url()),
button_one_icon_url_(notification.button_one_icon_url()),
button_two_icon_url_(notification.button_two_icon_url()),
image_url_(notification.image_url()),
@@ -90,7 +64,6 @@ Notification::~Notification() {}
Notification& Notification::operator=(const Notification& notification) {
message_center::Notification::operator=(notification);
origin_url_ = notification.origin_url();
- icon_url_ = notification.icon_url();
button_one_icon_url_ = notification.button_one_icon_url();
button_two_icon_url_ = notification.button_two_icon_url();
image_url_ = notification.image_url();

Powered by Google App Engine
This is Rietveld 408576698