Request the icon of a Web Notification in the renderer process.

chrome/browser/notifications/desktop_notification_service.cc

Index: chrome/browser/notifications/desktop_notification_service.cc
diff --git a/chrome/browser/notifications/desktop_notification_service.cc b/chrome/browser/notifications/desktop_notification_service.cc
index c53742b75fb2f626fc4704d57af2862bf9b577f7..399772e79ca1b2e95d422ea2569129c702b22118 100644
--- a/chrome/browser/notifications/desktop_notification_service.cc
+++ b/chrome/browser/notifications/desktop_notification_service.cc
@@ -157,9 +157,15 @@ void DesktopNotificationService::ShowDesktopNotification(
 
   base::string16 display_source = DisplayNameForOriginInProcessId(
       origin, render_frame_host->GetProcess()->GetID());
-  Notification notification(origin, params.icon_url, params.title,
-      params.body, params.direction, display_source, params.replace_id,
-      proxy);
+
+  Notification notification(origin,
+                            gfx::Image::CreateFrom1xBitmap(params.icon),

[dewittj, 2014/09/17 16:36:20]

I think that today, this will work for 1x and 2x displays as we've written the
views code but it is still risky; since the image will be marked as having only
a 1x representation.

I realize that this is a limitation of the current API, but possibly good to put
a TODO in here, to fix the image creation someday.

[Jun Mukai, 2014/09/17 16:57:47]

Using CreateFrom1xBitmap is not bad by itself, it will automatically rescaled in
Views size IIRC.  However, that means the scale could be blurry in some
situation, and specifying larger image for hidpi device may cause weird effect
of rescaling and shrinking (I haven't checked it though).

More thinking deeply, specifying single bitmap itself could be a bad idea by
itself because we have no idea what is the best image in some environment, like
Retina Macbook or Chromebook Pixel with normal external display -- the
notification card appears on both screens. But to address that issue, we need to
change the notification API to support such situation.

Until then, it would be good to put a TODO here.

[Peter Beverloo, 2014/09/18 16:54:37]

I agree that it would be good for the Notification API to support images of
different resolution (there's Android devices with 3x density out there), and
will pursue this for the HTML5 API.

I've added a TODO here for now.

+                            params.title,
+                            params.body,
+                            params.direction,
+                            display_source,
+                            params.replace_id,
+                            proxy);
 
   // The webkit notification doesn't timeout.
   notification.set_never_timeout(true);