Switch from gsdview.appspot.com to commondatastorage.googleapis.com.

Switch from gsdview.appspot.com to commondatastorage.googleapis.com. 

This server requires that unsafe characters are quoted in URLs, so we do that
here.

Change-Id: I6b7c430671b02a8da11777029b0fdb59a87dcae1

BUG=chromium-os:9902
TEST=Ran unit tests. Ran example buildbot run and diff'd new version and old
     version of Packages file.

[diandersAtChromium, 2010-12-02 23:03:21]

I assume that the point of this change is to somehow make the prebuilts
available to those outside of Google?  Is that right?


I don't see anything wrong (still skipped looking over unit tests, since still
haven't learned mox).  Please get a LGTM from someone with a better
understanding of the system before submitting, tho.

Random thoughts, though:
* Did you test the code path that prevents the "deduplication" stuff from
running when the host changes?  This will be the first time that uses it, right?

* Did you test to make sure that private packages won't be uploaded to the
public servers?

http://codereview.chromium.org/5542002/diff/2001/prebuilt.py
File prebuilt.py (right):

http://codereview.chromium.org/5542002/diff/2001/prebuilt.py#newcode315
prebuilt.py:315: suffix = pkg['CPV'] + '.tbz2'
Do you need to do escaping here?

[sosa, 2010-12-03 01:02:02]

LGTM

[davidjames, 2010-12-03 17:03:42]

On 2010/12/02 23:03:21, diandersAtChromium wrote:
> I assume that the point of this change is to somehow make the prebuilts
> available to those outside of Google?  Is that right?

No -- the prebuilts are already available publicly.

When we retrieve prebuilts, we currently go to gsdview.appspot.com, which then
redirects to commondatastorage.googleapis.com. In logs, we've seen that
gsdview.appspot.com sometimes fails, so we think that switching to going to
commondatastorage.googleapis.com directly will get more reliable performance. In
order to do this, though, we need to do the same escaping that gsdview does for
us.

> * Did you test the code path that prevents the "deduplication" stuff from
> running when the host changes?  This will be the first time that uses it,
right?

Yup, I did test this locally. Might be good to add a unit test. I'll think about
this.

> * Did you test to make sure that private packages won't be uploaded to the
> public servers?

This change doesn't change the uploading, so this part should be good.

Cheers,

David