Chromium Code Reviews
Help | Chromium Project | Sign in

Issue 5542002: Switch from to (Closed)

Can't Edit
Can't Publish+Mail
Start Review
6 years ago by davidjames
5 years, 4 months ago
CC:, Mandeep Singh Baines, anush, sosa


Switch from to This server requires that unsafe characters are quoted in URLs, so we do that here. Change-Id: I6b7c430671b02a8da11777029b0fdb59a87dcae1 BUG=chromium-os:9902 TEST=Ran unit tests. Ran example buildbot run and diff'd new version and old version of Packages file.

Patch Set 1 #

Patch Set 2 : 80 chars #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M chromite/lib/ View 3 chunks +4 lines, -2 lines 0 comments Download
M View 1 chunk +1 line, -2 lines 1 comment Download
M View 1 4 chunks +8 lines, -6 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).


Total messages: 4 (0 generated)
6 years ago (2010-12-02 21:03:56 UTC) #1
I assume that the point of this change is to somehow make the prebuilts available ...
6 years ago (2010-12-02 23:03:21 UTC) #2
6 years ago (2010-12-03 01:02:02 UTC) #3
6 years ago (2010-12-03 17:03:42 UTC) #4
On 2010/12/02 23:03:21, diandersAtChromium wrote:
> I assume that the point of this change is to somehow make the prebuilts
> available to those outside of Google?  Is that right?

No -- the prebuilts are already available publicly.

When we retrieve prebuilts, we currently go to, which then
redirects to In logs, we've seen that sometimes fails, so we think that switching to going to directly will get more reliable performance. In
order to do this, though, we need to do the same escaping that gsdview does for

> * Did you test the code path that prevents the "deduplication" stuff from
> running when the host changes?  This will be the first time that uses it,

Yup, I did test this locally. Might be good to add a unit test. I'll think about

> * Did you test to make sure that private packages won't be uploaded to the
> public servers?

This change doesn't change the uploading, so this part should be good.


Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f8e48bd