Add an alternate paintContents method to WebContentLayerClient.

Add an alternate paintContents method to WebContentLayerClient.

The new method does not take an opaque rect out-parameter. And the old
methods all just call the new method and discard the resulting opaque
rect.

Chromium side is not using this opaque rect anymore and we're removing
it there, so making the matching change to blink. This removes a call
to GraphicsContext::setRegionTrackingMode(), but there are others.

R=fmalita@chromium.org, jamesr@chromium.org, schenney@chromium.org
BUG=413479
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181996

[danakj, 2014-09-12 00:49:55]

danakj@chromium.org changed reviewers:
+ fmalita@chromium.org
- fmailita@chromium.org

[danakj, 2014-09-12 00:50:04]

Oops, typing. +florin

[danakj, 2014-09-12 16:02:51]

4 tests have off-by-one blending differences now that they are drawn with
blending on cuz skiabug. Marked them as NeedsRebaseline.

[danakj, 2014-09-12 16:03:05]

On 2014/09/12 16:02:51, danakj wrote:
> 4 tests have off-by-one blending differences now that they are drawn with
> blending on cuz skiabug. Marked them as NeedsRebaseline.

(The same thing would happen when we turn on implside painting also)

[danakj, 2014-09-13 02:02:55]

schenney: ping :)

[jamesr, 2014-09-15 17:38:11]

lgtm

https://codereview.chromium.org/554183004/diff/20001/Source/platform/graphics...
File Source/platform/graphics/ContentLayerDelegate.h (right):

https://codereview.chromium.org/554183004/diff/20001/Source/platform/graphics...
Source/platform/graphics/ContentLayerDelegate.h:56: // tracking opaqueness.
this bit isn't about tracking any more, it looks like, it's about
setCertainlyOpaque which controls whether LCD text is generated. can you update?

https://codereview.chromium.org/554183004/diff/20001/Source/platform/graphics...
Source/platform/graphics/ContentLayerDelegate.h:58: {
the one-line version seemed fine, imho, but if this is what clang-format does
then so be it

https://codereview.chromium.org/554183004/diff/20001/public/platform/WebConte...
File public/platform/WebContentLayerClient.h (right):

https://codereview.chromium.org/554183004/diff/20001/public/platform/WebConte...
public/platform/WebContentLayerClient.h:51: // TODO(danakj): Replace the above
method with this one.
it's blink, so FIXME: with no name

[danakj, 2014-09-15 17:41:55]

Thanks!

https://codereview.chromium.org/554183004/diff/20001/Source/platform/graphics...
File Source/platform/graphics/ContentLayerDelegate.h (right):

https://codereview.chromium.org/554183004/diff/20001/Source/platform/graphics...
Source/platform/graphics/ContentLayerDelegate.h:56: // tracking opaqueness.
On 2014/09/15 17:38:10, jamesr wrote:
> this bit isn't about tracking any more, it looks like, it's about
> setCertainlyOpaque which controls whether LCD text is generated. can you
update?

Done.

https://codereview.chromium.org/554183004/diff/20001/public/platform/WebConte...
File public/platform/WebContentLayerClient.h (right):

https://codereview.chromium.org/554183004/diff/20001/public/platform/WebConte...
public/platform/WebContentLayerClient.h:51: // TODO(danakj): Replace the above
method with this one.
On 2014/09/15 17:38:10, jamesr wrote:
> it's blink, so FIXME: with no name

Done.

[danakj, 2014-09-15 17:42:24]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-09-15 17:42:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/554183004/40001

[commit-bot: I haz the power, 2014-09-15 18:51:15]

Committed patchset #3 (id:40001) as 181996