Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: Source/platform/graphics/ContentLayerDelegate.h

Issue 554183004: Add an alternate paintContents method to WebContentLayerClient. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: opaquerecttracking: expectations Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND AN Y 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS'' AND AN Y
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
15 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE 15 * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
16 * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR AN Y 16 * DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS BE LIABLE FOR AN Y
17 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES 17 * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
18 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; 18 * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
19 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND O N 19 * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND O N
20 * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 20 * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
21 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS 21 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
22 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 22 * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
23 */ 23 */
24 24
25 #ifndef OpaqueRectTrackingContentLayerDelegate_h 25 #ifndef ContentLayerDelegate_h
26 #define OpaqueRectTrackingContentLayerDelegate_h 26 #define ContentLayerDelegate_h
27 27
28 #include "platform/PlatformExport.h" 28 #include "platform/PlatformExport.h"
29 #include "public/platform/WebContentLayerClient.h" 29 #include "public/platform/WebContentLayerClient.h"
30 #include "wtf/Noncopyable.h" 30 #include "wtf/Noncopyable.h"
31 #include "wtf/PassOwnPtr.h" 31 #include "wtf/PassOwnPtr.h"
32 32
33 class SkCanvas; 33 class SkCanvas;
34 34
35 namespace blink { 35 namespace blink {
36 36
37 class GraphicsContext; 37 class GraphicsContext;
38 class IntRect; 38 class IntRect;
39 39
40 class PLATFORM_EXPORT GraphicsContextPainter { 40 class PLATFORM_EXPORT GraphicsContextPainter {
41 public: 41 public:
42 virtual void paint(GraphicsContext&, const IntRect& clip) = 0; 42 virtual void paint(GraphicsContext&, const IntRect& clip) = 0;
43 43
44 protected: 44 protected:
45 virtual ~GraphicsContextPainter() { } 45 virtual ~GraphicsContextPainter() { }
46 }; 46 };
47 47
48 class PLATFORM_EXPORT OpaqueRectTrackingContentLayerDelegate : public WebContent LayerClient { 48 class PLATFORM_EXPORT ContentLayerDelegate : public WebContentLayerClient {
49 WTF_MAKE_NONCOPYABLE(OpaqueRectTrackingContentLayerDelegate); 49 WTF_MAKE_NONCOPYABLE(ContentLayerDelegate);
50
50 public: 51 public:
51 explicit OpaqueRectTrackingContentLayerDelegate(GraphicsContextPainter*); 52 explicit ContentLayerDelegate(GraphicsContextPainter*);
52 virtual ~OpaqueRectTrackingContentLayerDelegate(); 53 virtual ~ContentLayerDelegate();
53 54
54 // If we know that everything that will be painted through this delegate, th en we don't bother 55 // If we know that everything that will be painted through this delegate, th en we don't bother
55 // tracking opaqueness. 56 // tracking opaqueness.
jamesr 2014/09/15 17:38:10 this bit isn't about tracking any more, it looks l
danakj 2014/09/15 17:41:55 Done.
56 void setOpaque(bool opaque) { m_opaque = opaque; } 57 void setOpaque(bool opaque)
58 {
jamesr 2014/09/15 17:38:10 the one-line version seemed fine, imho, but if thi
59 m_opaque = opaque;
60 }
57 61
58 // WebContentLayerClient implementation. 62 // WebContentLayerClient implementation.
59 virtual void paintContents(SkCanvas*, const WebRect& clip, bool canPaintLCDT ext, WebFloatRect& opaque, 63 virtual void paintContents(SkCanvas*, const WebRect& clip, bool canPaintLCDT ext, WebFloatRect& opaque, WebContentLayerClient::GraphicsContextStatus = Graphi csContextEnabled) OVERRIDE;
60 WebContentLayerClient::GraphicsContextStatus = GraphicsContextEnabled) O VERRIDE; 64 virtual void paintContents(SkCanvas*, const WebRect& clip, bool canPaintLCDT ext, WebContentLayerClient::GraphicsContextStatus = GraphicsContextEnabled) OVER RIDE;
61 65
62 private: 66 private:
63 GraphicsContextPainter* m_painter; 67 GraphicsContextPainter* m_painter;
64 bool m_opaque; 68 bool m_opaque;
65 }; 69 };
66 70
67 } // namespace blink 71 } // namespace blink
68 72
69 #endif // OpaqueRectTrackingContentLayerDelegate_h 73 #endif // ContentLayerDelegate_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698