Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 554163002: Sandbox: Don't CloseHandle after calling DuplicateHandle (Closed)

Created:
6 years, 3 months ago by rvargas (doing something else)
Modified:
6 years, 3 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Sandbox: Don't CloseHandle after calling DuplicateHandle DuplicateHandle closes the handle even if there's an error. BUG=412200 R=cpu@chromium.org Committed: https://crrev.com/821423d3d8c62296380eb33c6abb1aa758b80986 Cr-Commit-Position: refs/heads/master@{#294078}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M sandbox/win/src/process_thread_policy.cc View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rvargas (doing something else)
6 years, 3 months ago (2014-09-09 01:45:00 UTC) #1
cpu_(ooo_6.6-7.5)
d'oh! lgtm
6 years, 3 months ago (2014-09-10 00:48:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/554163002/1
6 years, 3 months ago (2014-09-10 01:09:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as c9119a2ef0bba28f7364054dcc70293c1b084ad4
6 years, 3 months ago (2014-09-10 02:21:07 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:57:48 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/821423d3d8c62296380eb33c6abb1aa758b80986
Cr-Commit-Position: refs/heads/master@{#294078}

Powered by Google App Engine
This is Rietveld 408576698