Sandbox: Don't CloseHandle after calling DuplicateHandle

sandbox/win/src/process_thread_policy.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sandbox/win/src/process_thread_policy.h"
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "sandbox/win/src/ipc_tags.h"
@@ skipping 106 matching lines @@
   client_id.UniqueThread =
       reinterpret_cast<PVOID>(static_cast<ULONG_PTR>(thread_id));
 
   HANDLE local_handle;
   NTSTATUS status = NtOpenThread(&local_handle, desired_access, &attributes,
                                  &client_id);
   if (NT_SUCCESS(status)) {
     if (!::DuplicateHandle(::GetCurrentProcess(), local_handle,
                            client_info.process, handle, 0, FALSE,
                            DUPLICATE_CLOSE_SOURCE | DUPLICATE_SAME_ACCESS)) {
-      ::CloseHandle(local_handle);
       return STATUS_ACCESS_DENIED;
     }
   }
 
   return status;
 }
 
 NTSTATUS ProcessPolicy::OpenProcessAction(const ClientInfo& client_info,
                                           uint32 desired_access,
                                           uint32 process_id,
@@ skipping 11 matching lines @@
   CLIENT_ID client_id = {0};
   client_id.UniqueProcess = reinterpret_cast<PVOID>(
                                 static_cast<ULONG_PTR>(client_info.process_id));
   HANDLE local_handle;
   NTSTATUS status = NtOpenProcess(&local_handle, desired_access, &attributes,
                                   &client_id);
   if (NT_SUCCESS(status)) {
     if (!::DuplicateHandle(::GetCurrentProcess(), local_handle,
                            client_info.process, handle, 0, FALSE,
                            DUPLICATE_CLOSE_SOURCE | DUPLICATE_SAME_ACCESS)) {
-      ::CloseHandle(local_handle);
       return STATUS_ACCESS_DENIED;
     }
   }
 
   return status;
 }
 
 NTSTATUS ProcessPolicy::OpenProcessTokenAction(const ClientInfo& client_info,
                                                HANDLE process,
                                                uint32 desired_access,
                                                HANDLE* handle) {
   *handle = NULL;
   NtOpenProcessTokenFunction NtOpenProcessToken = NULL;
   ResolveNTFunctionPtr("NtOpenProcessToken", &NtOpenProcessToken);
 
   if (CURRENT_PROCESS != process)
     return STATUS_ACCESS_DENIED;
 
   HANDLE local_handle;
   NTSTATUS status = NtOpenProcessToken(client_info.process, desired_access,
                                        &local_handle);
   if (NT_SUCCESS(status)) {
     if (!::DuplicateHandle(::GetCurrentProcess(), local_handle,
                            client_info.process, handle, 0, FALSE,
                            DUPLICATE_CLOSE_SOURCE | DUPLICATE_SAME_ACCESS)) {
-      ::CloseHandle(local_handle);
       return STATUS_ACCESS_DENIED;
     }
   }
   return status;
 }
 
 NTSTATUS ProcessPolicy::OpenProcessTokenExAction(const ClientInfo& client_info,
                                                  HANDLE process,
                                                  uint32 desired_access,
                                                  uint32 attributes,
                                                  HANDLE* handle) {
   *handle = NULL;
   NtOpenProcessTokenExFunction NtOpenProcessTokenEx = NULL;
   ResolveNTFunctionPtr("NtOpenProcessTokenEx", &NtOpenProcessTokenEx);
 
   if (CURRENT_PROCESS != process)
     return STATUS_ACCESS_DENIED;
 
   HANDLE local_handle;
   NTSTATUS status = NtOpenProcessTokenEx(client_info.process, desired_access,
                                          attributes, &local_handle);
   if (NT_SUCCESS(status)) {
     if (!::DuplicateHandle(::GetCurrentProcess(), local_handle,
                            client_info.process, handle, 0, FALSE,
                            DUPLICATE_CLOSE_SOURCE | DUPLICATE_SAME_ACCESS)) {
-      ::CloseHandle(local_handle);
       return STATUS_ACCESS_DENIED;
     }
   }
   return status;
 }
 
 DWORD ProcessPolicy::CreateProcessWAction(EvalResult eval_result,
                                           const ClientInfo& client_info,
                                           const base::string16 &app_name,
                                           const base::string16 &command_line,
@@ skipping 12 matching lines @@
   if (!CreateProcessExWHelper(client_info.process, should_give_full_access,
                               app_name.c_str(), cmd_line.get(), NULL, NULL,
                               FALSE, 0, NULL, NULL, &startup_info,
                               process_info)) {
     return ERROR_ACCESS_DENIED;
   }
   return ERROR_SUCCESS;
 }
 
 }  // namespace sandbox