Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 553983012: Turn off autofill highlight when changing option in an autofilled <select> element (Closed)

Created:
6 years, 3 months ago by ziran.sun
Modified:
6 years, 3 months ago
Reviewers:
tkent, Ilya Sherman
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Turn off autofill highlight when changing option in an autofilled <select> element R=isherman@chromium.org, tkent@chromium.org BUG=412311 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182528

Patch Set 1 #

Patch Set 2 : Rebase and add test code. #

Patch Set 3 : Add NeedRebaseline for test code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M LayoutTests/fast/forms/autofilled.html View 1 6 chunks +15 lines, -1 line 0 comments Download
M LayoutTests/fast/forms/autofilled-expected.txt View 1 3 chunks +5 lines, -1 line 0 comments Download
M LayoutTests/platform/linux/fast/forms/autofilled-expected.txt View 1 3 chunks +5 lines, -1 line 0 comments Download
M LayoutTests/platform/win-xp/fast/forms/autofilled-expected.txt View 1 2 chunks +4 lines, -0 lines 0 comments Download
M LayoutTests/platform/win/fast/forms/autofilled-expected.txt View 1 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/html/HTMLSelectElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 4 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Ilya Sherman
Please add test coverage for this change. Otherwise, I defer to tkent@.
6 years, 3 months ago (2014-09-20 00:54:34 UTC) #1
ziran.sun
Please review. Thanks!
6 years, 3 months ago (2014-09-23 15:52:34 UTC) #2
tkent
lgtm
6 years, 3 months ago (2014-09-23 22:37:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/553983012/40001
6 years, 3 months ago (2014-09-23 22:38:41 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 182528
6 years, 3 months ago (2014-09-23 23:59:36 UTC) #6
Mads Ager (chromium)
6 years, 3 months ago (2014-09-24 07:23:58 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/597853004/ by ager@chromium.org.

The reason for reverting is: This makes the
FormAutofillTest.ClearFormWithNodeContainingSelectOne browser_test fail.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=For....

Powered by Google App Engine
This is Rietveld 408576698