Issue 553983003: Revert of Fix two SkRecord-backed layer hoisting bugs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 553983003: Revert of Fix two SkRecord-backed layer hoisting bugs (Closed)

Created:
6 years, 3 months ago by robertphillips

Modified:
6 years, 3 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Revert of Fix two SkRecord-backed layer hoisting bugs (patchset #1 id:1 of https://codereview.chromium.org/551843002/) Reason for revert: turning bots red Original issue's description: > Fix two SkRecord-backed layer hoisting bugs > > The two bugs are/were: > The old loop to draw the hoisted layers included the saveLayer call which caused double application of the layer's paint (This is the +1 change). > > The hoisted layer is intended to be drawn in device coordinates. The old code was drawing it in the coordinate space of the saveLayer thus it was misplaced (This is the setMatrix change). > > Committed: https://skia.googlesource.com/skia/+/7c0cfd4ff8f6db50a8731c886db732b106268937 TBR=bsalomon@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/224310941e01b62b9b45db8656261a3d936cecf5

Created: 6 years, 3 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -12 lines)			Patch
	M	src/gpu/GrLayerHoister.cpp	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	src/gpu/GrRecordReplaceDraw.cpp	View		4 chunks	+4 lines, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

robertphillips

Created Revert of Fix two SkRecord-backed layer hoisting bugs

6 years, 3 months ago (2014-09-08 17:10:19 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/553983003/1

6 years, 3 months ago (2014-09-08 17:10:46 UTC) #2

commit-bot: I haz the power

6 years, 3 months ago (2014-09-08 17:10:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 224310941e01b62b9b45db8656261a3d936cecf5