Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Issue 551843002: Fix two SkRecord-backed layer hoisting bugs (Closed)

Created:
6 years, 3 months ago by robertphillips
Modified:
6 years, 3 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix two SkRecord-backed layer hoisting bugs The two bugs are/were: The old loop to draw the hoisted layers included the saveLayer call which caused double application of the layer's paint (This is the +1 change). The hoisted layer is intended to be drawn in device coordinates. The old code was drawing it in the coordinate space of the saveLayer thus it was misplaced (This is the setMatrix change). Committed: https://skia.googlesource.com/skia/+/7c0cfd4ff8f6db50a8731c886db732b106268937 Committed: https://skia.googlesource.com/skia/+/46625e06e23b65c05013fc686a8223d6d5b49050

Patch Set 1 #

Patch Set 2 : Fix unit test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M src/gpu/GrLayerHoister.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/GrRecordReplaceDraw.cpp View 4 chunks +10 lines, -4 lines 0 comments Download
M tests/RecordReplaceDrawTest.cpp View 1 1 chunk +7 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
robertphillips
6 years, 3 months ago (2014-09-08 15:27:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/551843002/1
6 years, 3 months ago (2014-09-08 16:43:06 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 3 months ago (2014-09-08 16:43:07 UTC) #5
bsalomon
lgtm
6 years, 3 months ago (2014-09-08 16:52:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7c0cfd4ff8f6db50a8731c886db732b106268937
6 years, 3 months ago (2014-09-08 16:54:02 UTC) #7
robertphillips
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/553983003/ by robertphillips@google.com. ...
6 years, 3 months ago (2014-09-08 17:10:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/551843002/20001
6 years, 3 months ago (2014-09-08 18:30:57 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 18:38:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 46625e06e23b65c05013fc686a8223d6d5b49050

Powered by Google App Engine
This is Rietveld 408576698