Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 553973002: Remove debug-only ref of GrEffectStage (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 3 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : revert grrodrawstate.h #

Total comments: 3

Patch Set 3 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M include/gpu/GrEffectStage.h View 1 2 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bsalomon
6 years, 3 months ago (2014-09-08 15:31:58 UTC) #2
robertphillips
lgtm - do we want to preserve all the old checks though ? https://codereview.chromium.org/553973002/diff/20001/include/gpu/GrEffectStage.h File ...
6 years, 3 months ago (2014-09-08 15:38:09 UTC) #3
bsalomon
did all the suggestions.
6 years, 3 months ago (2014-09-08 16:53:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/553973002/40001
6 years, 3 months ago (2014-09-08 17:38:46 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 17:46:01 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 18444b1649562c45e5496507cfdc10a796525d67

Powered by Google App Engine
This is Rietveld 408576698