Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 553933002: Revert of Changes exception for gyp files to only gyp files in build/ (Closed)

Created:
6 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 3 months ago
Reviewers:
Nico, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Changes exception for gyp files to only gyp files in build/ (patchset #1 id:1 of https://codereview.chromium.org/512693004/) Reason for revert: gyp change this depended on was reverted Original issue's description: > Changes exception for gyp files to only gyp files in build/ > > I changed analyzer such that if a gyp file (or an included gypi file) > changes all targets in the gyp file are marked as changed. This means > I should no longer have to special case gyp files. I'm leaving the > exception in place for any gyp files in build as any change to those > really needs to recompile the world. > > BUG=109173 > TEST=none > R=thakis@chromium.org > > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b > > Committed: https://chromium.googlesource.com/chromium/src/+/e53e29fc161f96871160f6db39919752a0376333 > > Committed: https://chromium.googlesource.com/chromium/src/+/5c361bce306a985bcb65cd9db6060ccbe139f66d TBR=thakis@chromium.org,sky@chromium.org NOTREECHECKS=true NOTRY=true BUG=109173 Committed: https://crrev.com/7e1fe2737bab8048e5508538ebccdeec67dcaff3 Cr-Commit-Position: refs/heads/master@{#293713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/buildbot/trybot_analyze_config.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
Created Revert of Changes exception for gyp files to only gyp files in build/
6 years, 3 months ago (2014-09-08 13:14:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/553933002/1
6 years, 3 months ago (2014-09-08 13:15:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 305c93948d52a6c01da317bedae5b29d9da4fd01
6 years, 3 months ago (2014-09-08 13:17:17 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:45:53 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e1fe2737bab8048e5508538ebccdeec67dcaff3
Cr-Commit-Position: refs/heads/master@{#293713}

Powered by Google App Engine
This is Rietveld 408576698