Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 512693004: Changes exception for gyp files to only gyp files in build/ (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Changes exception for gyp files to only gyp files in build/ I changed analyzer such that if a gyp file (or an included gypi file) changes all targets in the gyp file are marked as changed. This means I should no longer have to special case gyp files. I'm leaving the exception in place for any gyp files in build as any change to those really needs to recompile the world. BUG=109173 TEST=none R=thakis@chromium.org Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/5110e8b Committed: https://chromium.googlesource.com/chromium/src/+/e53e29fc161f96871160f6db39919752a0376333 Committed: https://chromium.googlesource.com/chromium/src/+/5c361bce306a985bcb65cd9db6060ccbe139f66d Committed: https://crrev.com/3f631981fd3ecd25ecda9497c19e63f25a557313 Cr-Commit-Position: refs/heads/master@{#293983}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/buildbot/trybot_analyze_config.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (0 generated)
sky
6 years, 3 months ago (2014-08-28 13:20:42 UTC) #1
Nico
"""I changed analyzer such that if a gyp file (or an included gypi file) changes ...
6 years, 3 months ago (2014-08-28 14:48:44 UTC) #2
sky
On Thu, Aug 28, 2014 at 7:48 AM, <thakis@chromium.org> wrote: > """I changed analyzer such ...
6 years, 3 months ago (2014-08-28 15:32:12 UTC) #3
Nico
On Thu, Aug 28, 2014 at 8:32 AM, Scott Violet <sky@chromium.org> wrote: > On Thu, ...
6 years, 3 months ago (2014-08-28 15:36:39 UTC) #4
sky
On Thu, Aug 28, 2014 at 8:36 AM, Nico Weber <thakis@chromium.org> wrote: > On Thu, ...
6 years, 3 months ago (2014-08-28 15:47:31 UTC) #5
Nico
> For the example you give 'chrome' would be output as a build_target as > ...
6 years, 3 months ago (2014-08-28 15:51:53 UTC) #6
sky
Committed patchset #1 (id:1) to pending queue manually as 5110e8b (presubmit successful).
6 years, 3 months ago (2014-08-28 15:57:19 UTC) #7
sky
I'm reverting this. http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/6806 should have triggered a compile.
6 years, 3 months ago (2014-08-28 17:21:27 UTC) #8
sky
A revert of this CL (patchset #1) has been created in https://codereview.chromium.org/512303002/ by sky@chromium.org. The ...
6 years, 3 months ago (2014-08-28 17:21:46 UTC) #9
sky
I fixed the problem in the analyzer side and rolled deps. So, I'm going to ...
6 years, 3 months ago (2014-09-03 15:35:21 UTC) #10
Nico
ok!
6 years, 3 months ago (2014-09-03 15:40:26 UTC) #11
sky
Committed patchset #1 (id:1) manually as e53e29f (presubmit successful).
6 years, 3 months ago (2014-09-03 15:41:26 UTC) #12
sky
On 2014/09/03 15:41:26, sky wrote: > Committed patchset #1 (id:1) manually as e53e29f (presubmit successful). ...
6 years, 3 months ago (2014-09-03 19:59:18 UTC) #13
sky
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/537683002/ by sky@chromium.org. ...
6 years, 3 months ago (2014-09-03 19:59:31 UTC) #14
sky
I'm trying this for a third time. Hopefully it sticks.
6 years, 3 months ago (2014-09-05 19:04:26 UTC) #15
sky
Committed patchset #1 (id:1) manually as 5c361bc (presubmit successful).
6 years, 3 months ago (2014-09-05 19:08:12 UTC) #16
jochen (gone - plz use gerrit)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/553933002/ by jochen@chromium.org. ...
6 years, 3 months ago (2014-09-08 13:14:55 UTC) #17
sky
Reopenning and trying for a 4th time. Yeesh!
6 years, 3 months ago (2014-09-09 19:14:17 UTC) #18
sky
Committed patchset #1 (id:1) manually as 3f63198 (presubmit successful).
6 years, 3 months ago (2014-09-09 19:21:09 UTC) #19
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/623d2d8aae03f12cc9854b9f9c26afeb82da2ea4 Cr-Commit-Position: refs/heads/master@{#292392}
6 years, 3 months ago (2014-09-10 02:59:54 UTC) #20
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e53e29fc161f96871160f6db39919752a0376333 Cr-Commit-Position: refs/heads/master@{#293139}
6 years, 3 months ago (2014-09-10 03:25:50 UTC) #21
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5c361bce306a985bcb65cd9db6060ccbe139f66d Cr-Commit-Position: refs/heads/master@{#293565}
6 years, 3 months ago (2014-09-10 03:41:05 UTC) #22
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:54:46 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3f631981fd3ecd25ecda9497c19e63f25a557313
Cr-Commit-Position: refs/heads/master@{#293983}

Powered by Google App Engine
This is Rietveld 408576698