Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3242)

Unified Diff: base/win/shortcut.cc

Issue 553783005: Remove the IShellLink::Resolve step in ResolveShortcutProperties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win/shortcut.cc
diff --git a/base/win/shortcut.cc b/base/win/shortcut.cc
index f56db9fb005170a3dd3d2f306431b1721dc0943c..eef299b9440fab413bca51e781fc164e63586a30 100644
--- a/base/win/shortcut.cc
+++ b/base/win/shortcut.cc
@@ -204,9 +204,6 @@ bool ResolveShortcutProperties(const FilePath& shortcut_path,
wchar_t temp[MAX_PATH];
if (options & ShortcutProperties::PROPERTIES_TARGET) {
grt (UTC plus 2) 2014/09/09 16:54:34 maybe document in the .h file that resolving the t
gab 2014/09/09 18:30:44 Done.
- // Try to find the target of a shortcut.
- if (FAILED(i_shell_link->Resolve(0, SLR_NO_UI | SLR_NOSEARCH)))
- return false;
if (FAILED(i_shell_link->GetPath(temp, MAX_PATH, NULL, SLGP_UNCPRIORITY)))
return false;
properties->set_target(FilePath(temp));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698