Remove the IShellLink::Resolve step in ResolveShortcutProperties.

base/win/shortcut.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/win/shortcut.h"
 
 #include <shellapi.h>
 #include <shlobj.h>
 #include <propkey.h>
 
@@ skipping 185 matching lines @@
     return false;
 
   // Load the shell link.
   if (FAILED(persist->Load(shortcut_path.value().c_str(), STGM_READ)))
     return false;
 
   // Reset |properties|.
   properties->options = 0;
 
   wchar_t temp[MAX_PATH];
   if (options & ShortcutProperties::PROPERTIES_TARGET) {

[grt (UTC plus 2), 2014/09/09 16:54:34]

maybe document in the .h file that resolving the target retrieves the path from
the shortcut without doing the full resolution.

[gab, 2014/09/09 18:30:44]

Done.

-    // Try to find the target of a shortcut.
-    if (FAILED(i_shell_link->Resolve(0, SLR_NO_UI | SLR_NOSEARCH)))
-      return false;
     if (FAILED(i_shell_link->GetPath(temp, MAX_PATH, NULL, SLGP_UNCPRIORITY)))
       return false;
     properties->set_target(FilePath(temp));
   }
 
   if (options & ShortcutProperties::PROPERTIES_WORKING_DIR) {
     if (FAILED(i_shell_link->GetWorkingDirectory(temp, MAX_PATH)))
       return false;
     properties->set_working_dir(FilePath(temp));
   }
@@ skipping 107 matching lines @@
   if (GetVersion() < VERSION_WIN7)
     return false;
 
   int result = reinterpret_cast<int>(ShellExecute(NULL, L"taskbarunpin",
       shortcut, NULL, NULL, 0));
   return result > 32;
 }
 
 }  // namespace win
 }  // namespace base