Remove the IShellLink::Resolve step in ResolveShortcutProperties.

Committed: https://crrev.com/8d5adf5b8a017eeb9e3a6972b77725a1a8b1709b
Cr-Commit-Position: refs/heads/master@{#293986}

[gab, 2014-09-09 14:58:41]

gab@chromium.org changed reviewers:
+ grt@chromium.org

[grt (UTC plus 2), 2014-09-09 16:54:34]

lgtm w/ comment nit

https://codereview.chromium.org/553783005/diff/1/base/win/shortcut.cc
File base/win/shortcut.cc (left):

https://codereview.chromium.org/553783005/diff/1/base/win/shortcut.cc#oldcode206
base/win/shortcut.cc:206: if (options & ShortcutProperties::PROPERTIES_TARGET) {
maybe document in the .h file that resolving the target retrieves the path from
the shortcut without doing the full resolution.

[gab, 2014-09-09 18:30:44]

Thanks, comment updated.

https://codereview.chromium.org/553783005/diff/1/base/win/shortcut.cc
File base/win/shortcut.cc (left):

https://codereview.chromium.org/553783005/diff/1/base/win/shortcut.cc#oldcode206
base/win/shortcut.cc:206: if (options & ShortcutProperties::PROPERTIES_TARGET) {
On 2014/09/09 16:54:34, grt wrote:
> maybe document in the .h file that resolving the target retrieves the path
from
> the shortcut without doing the full resolution.

Done.

[gab, 2014-09-09 18:30:59]

The CQ bit was checked by gab@chromium.org

[gab, 2014-09-09 18:33:25]

The CQ bit was unchecked by gab@chromium.org

[gab, 2014-09-09 18:33:55]

gab@chromium.org changed reviewers:
+ cpu@chromium.org

[gab, 2014-09-09 18:33:56]

Carlos PTAL as owner of base/win

Thanks,
Gab

[cpu_(ooo_6.6-7.5), 2014-09-09 19:23:27]

lgtm

[gab, 2014-09-09 19:27:38]

Committed patchset #2 to pending queue manually as 48a5546 (presubmit
successful).

[gab, 2014-09-09 19:28:35]

On 2014/09/09 19:27:38, gab wrote:
> Committed patchset #2 to pending queue manually as 48a5546 (presubmit
> successful).

Patch set 1 had green runs and patch set 2 was only a comment change.

[commit-bot: I haz the power, 2014-09-10 03:54:55]

Patchset 2 (id:??) landed as
https://crrev.com/8d5adf5b8a017eeb9e3a6972b77725a1a8b1709b
Cr-Commit-Position: refs/heads/master@{#293986}