Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 553603002: [ServiceWorker] Introduce isControlledByServiceWorker() in content::RenderFrameImpl (Closed)

Created:
6 years, 3 months ago by horo
Modified:
6 years, 3 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorker] Introduce isControlledByServiceWorker() in content::RenderFrameImpl We need to check this in DocumentThreadableLoader not to send CORS preflight requests to the ServiceWorker. Blink side is implemented in https://codereview.chromium.org/546263002/. BUG=411151 Committed: https://crrev.com/96d38dadb4ef427e56542c7316b755d47de680e4 Cr-Commit-Position: refs/heads/master@{#294156}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : isControlledByServiceWorker #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M content/renderer/render_frame_impl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
horo
nhiroki@ Could you please review this?
6 years, 3 months ago (2014-09-08 05:05:16 UTC) #3
nhiroki
LGTM from ServiceWorker's POV
6 years, 3 months ago (2014-09-08 05:31:19 UTC) #4
nhiroki
I forgot to publish a comment... https://codereview.chromium.org/553603002/diff/20001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://codereview.chromium.org/553603002/diff/20001/content/renderer/render_frame_impl.cc#newcode3205 content/renderer/render_frame_impl.cc:3205: kInvalidServiceWorkerHandleId; nit: Maybe ...
6 years, 3 months ago (2014-09-08 05:45:34 UTC) #5
horo
https://codereview.chromium.org/553603002/diff/20001/content/renderer/render_frame_impl.cc File content/renderer/render_frame_impl.cc (right): https://codereview.chromium.org/553603002/diff/20001/content/renderer/render_frame_impl.cc#newcode3205 content/renderer/render_frame_impl.cc:3205: kInvalidServiceWorkerHandleId; On 2014/09/08 05:45:33, nhiroki wrote: > nit: Maybe ...
6 years, 3 months ago (2014-09-08 06:24:25 UTC) #6
horo
jochen@ Could you please review this?
6 years, 3 months ago (2014-09-08 08:34:22 UTC) #8
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-10 08:15:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/553603002/60001
6 years, 3 months ago (2014-09-10 08:39:39 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:60001) as c2c0f2be2c9f5566e2bb10ae43e6f3aa8e9eb918
6 years, 3 months ago (2014-09-10 10:33:06 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 10:56:29 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/96d38dadb4ef427e56542c7316b755d47de680e4
Cr-Commit-Position: refs/heads/master@{#294156}

Powered by Google App Engine
This is Rietveld 408576698