Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 5536001: Merge 73052 - 2010-12-01 Ryosuke Niwa <rniwa@webkit.org>... (Closed)

Created:
10 years ago by rniwa-cr
Modified:
9 years, 6 months ago
Reviewers:
rniwa
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/597/
Visibility:
Public.

Description

Merge 73052 - 2010-12-01 Ryosuke Niwa <rniwa@webkit.org>; Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci. chrome.dll!WebCore::RangeBoundaryPoint::toPosition ReadAV@NULL (cf0d0f28bc56f2591cc74f71b46036ea) https://bugs.webkit.org/show_bug.cgi?id=47808 The crash was caused by moveParagraphWithClones' not copying the entire paragraph when called by doApplyForSingleParagraph, which was induced by a bug in cloneParagraphUnderNewElement which ended the cloning process early when the start node and the end node didn't share the same parent node. Fixed the bug in cloneParagraphUnderNewElement by calling traverseNextSibling(outerNode) instead of nextSibling(). Also added an early exit to InsertListCommand::doApply when lastSelectionRange is null. Tests: editing/execCommand/switch-multiple-list-items-crash.html editing/execCommand/switch-multiple-list-items.html * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): * editing/InsertListCommand.cpp: (WebCore::InsertListCommand::doApply): 2010-12-01 Ryosuke Niwa <rniwa@webkit.org>; Reviewed by Darin Adler, Tony Chang, and unofficially by Enrica Casucci. chrome.dll!WebCore::RangeBoundaryPoint::toPosition ReadAV@NULL (cf0d0f28bc56f2591cc74f71b46036ea) https://bugs.webkit.org/show_bug.cgi?id=47808 Added tests to ensure WebKit can switch the type of multiple list items without a crash. * editing/execCommand/switch-multiple-list-items-crash-expected.txt: Added. * editing/execCommand/switch-multiple-list-items-crash.html: Added. * editing/execCommand/switch-multiple-list-items-expected.txt: Added. * editing/execCommand/switch-multiple-list-items.html: Added. TBR=rniwa@webkit.org BUG=59557 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73085

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, --2 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +14 lines, -0 lines 0 comments Download
A + LayoutTests/editing/execCommand/switch-multiple-list-items.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/editing/execCommand/switch-multiple-list-items-crash.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/editing/execCommand/switch-multiple-list-items-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/editing/execCommand/switch-multiple-list-items-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M WebCore/ChangeLog View 1 chunk +23 lines, -0 lines 0 comments Download
M WebCore/editing/CompositeEditCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M WebCore/editing/InsertListCommand.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
rniwa-cr
10 years ago (2010-12-02 00:21:19 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698