Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2555)

Unified Diff: chrome/browser/resources/options/options.js

Issue 553573003: Compile chrome://settings, part 3: 167 proper errors left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@G_options_errors_1
Patch Set: mark narrow type in createItem JSDoc Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/options.js
diff --git a/chrome/browser/resources/options/options.js b/chrome/browser/resources/options/options.js
index be478545c3eec70559343f31f2d6091a0a56d0c8..5c2bebb0edc33ada062c6a283b44e7299e1881b3 100644
--- a/chrome/browser/resources/options/options.js
+++ b/chrome/browser/resources/options/options.js
@@ -91,8 +91,8 @@ function load() {
'doNotTrackConfirm',
loadTimeData.getString('doNotTrackConfirmOverlayTabTitle'),
'do-not-track-confirm-overlay',
- $('do-not-track-confirm-ok'),
- $('do-not-track-confirm-cancel'),
+ /** @type {HTMLInputElement} */($('do-not-track-confirm-ok')),
+ /** @type {HTMLInputElement} */($('do-not-track-confirm-cancel')),
$('do-not-track-enabled').pref,
$('do-not-track-enabled').metric),
BrowserOptions.getInstance());
@@ -104,8 +104,8 @@ function load() {
'spellingConfirm',
loadTimeData.getString('spellingConfirmOverlayTabTitle'),
'spelling-confirm-overlay',
- $('spelling-confirm-ok'),
- $('spelling-confirm-cancel'),
+ /** @type {HTMLInputElement} */($('spelling-confirm-ok')),
+ /** @type {HTMLInputElement} */($('spelling-confirm-cancel')),
$('spelling-enabled-control').pref,
$('spelling-enabled-control').metric),
BrowserOptions.getInstance());
@@ -260,7 +260,7 @@ function load() {
window.setTimeout(function() {
document.documentElement.classList.remove('loading');
chrome.send('onFinishedLoadingOptions');
- });
+ }, 0);
}
document.documentElement.classList.add('loading');

Powered by Google App Engine
This is Rietveld 408576698