chrome/browser/resources/options/inline_editable_list.js - Issue 553573003: Compile chrome://settings, part 3: 167 proper errors left

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/inline_editable_list.js

Issue 553573003: Compile chrome://settings, part 3: 167 proper errors left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@G_options_errors_1

Patch Set: mark narrow type in createItem JSDoc Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/controlled_setting.js ('K') | « chrome/browser/resources/options/deletable_item_list.js ('k') | chrome/browser/resources/options/options.js » ('j') | chrome/browser/resources/options/supervised_user_list.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/inline_editable_list.js

diff --git a/chrome/browser/resources/options/inline_editable_list.js b/chrome/browser/resources/options/inline_editable_list.js

index cc6c9f7c3e1d9052a6a98c48d24b6f3fd7fe92dc..89d10e7309592acb2871034315782d7fcaef7e6f 100644

--- a/chrome/browser/resources/options/inline_editable_list.js

+++ b/chrome/browser/resources/options/inline_editable_list.js

@@ -236,8 +236,9 @@ cr.define('options', function() {

* @private

createEditableTextCell: function(text) {

- var container = this.ownerDocument.createElement('div');

- var textEl;

+ var container = /** @type {HTMLElement} */(

+ this.ownerDocument.createElement('div'));

+ var textEl = null;

if (!this.isPlaceholder) {

textEl = this.ownerDocument.createElement('div');

textEl.className = 'static-text';

@@ -406,6 +407,10 @@ cr.define('options', function() {

}

handleWindowBlurs();

+ /**

+ * @constructor

+ * @extends {options.DeletableItemList}

+ */

var InlineEditableItemList = cr.ui.define('list');

InlineEditableItemList.prototype = {