chrome/browser/resources/options/chromeos/internet_detail.js - Issue 553573003: Compile chrome://settings, part 3: 167 proper errors left

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/chromeos/internet_detail.js

Issue 553573003: Compile chrome://settings, part 3: 167 proper errors left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@G_options_errors_1

Patch Set: mark narrow type in createItem JSDoc Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/chromeos/display_options.js ('K') | « chrome/browser/resources/options/chromeos/display_options.js ('k') | chrome/browser/resources/options/chromeos/network_list.js » ('j') | chrome/browser/resources/options/confirm_dialog.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/chromeos/internet_detail.js

diff --git a/chrome/browser/resources/options/chromeos/internet_detail.js b/chrome/browser/resources/options/chromeos/internet_detail.js

index f0dcbfc81dcd5cb5f8c7e92558f9580df188c7a4..2f1dc30f23126349ef4ab891f60861a77f78131d 100644

--- a/chrome/browser/resources/options/chromeos/internet_detail.js

+++ b/chrome/browser/resources/options/chromeos/internet_detail.js

@@ -11,18 +11,31 @@

// networkingPrivate API. See network_config.js.

// See crbug.com/279351 for more info.

+/** @typedef {{address: (string|undefined),

+ * gateway: (string|undefined),

+ * nameServers: (string|undefined),

+ * netmask: (string|undefined),

+ * prefixLength: (number|undefined)}}

+ * @see chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc

+ */

+var IPInfo;

/** @typedef {{activationState: (string|undefined),

* carriers: Array,

- * currentCarrierIndex; (number|undefined),

+ * currentCarrierIndex: (number|undefined),

+ * deviceConnected: boolean,

+ * errorMessage: string,

* ipAutoConfig: boolean,

- * ipconfig: Object,

+ * ipconfig: IPInfo,

* nameServerType: string,

* restrictedPool: (string|undefined),

* roamingState: (string|undefined),

* savedIP: Object,

- * showActivateButton: (boolean|undefined)

+ * servicePath: string,

+ * shared: boolean,

+ * showActivateButton: (boolean|undefined),

* showViewAccountButton: (boolean|undefined),

- * staticIP: Object}}

+ * staticIP: IPInfo}}

* Only the keys which had caused problems are declared in this typedef.

* There are many more of them.

* @see chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc