Compile chrome://settings, part 3: 167 proper errors left

chrome/browser/resources/options/confirm_dialog.js

Index: chrome/browser/resources/options/confirm_dialog.js
diff --git a/chrome/browser/resources/options/confirm_dialog.js b/chrome/browser/resources/options/confirm_dialog.js
index cbce2751163a599b408ad75f71b1f3ad68f71ba1..347c056b4b228a1524c279126df3379f3f1c3196 100644
--- a/chrome/browser/resources/options/confirm_dialog.js
+++ b/chrome/browser/resources/options/confirm_dialog.js
@@ -18,18 +18,18 @@ cr.define('options', function() {
    * @param {HTMLInputElement} cancelButton The cancellation button element.
    * @param {string} pref The pref that requires confirmation.
    * @param {string} metric User metrics identifier.
-   * @param {string} confirmed_pref A pref used to remember whether the user has
-   *     confirmed the dialog before. This ensures that the user is presented
-   *     with the dialog only once. If left |undefined| or |null|, the dialog
+   * @param {string=} opt_confirmed_pref A pref used to remember whether the

[Dan Beam, 2014/09/11 02:53:09]

nit: opt_confirmedPref (confirmed_pref -> confirmedPref)

[Vitaly Pavlenko, 2014/09/11 04:16:25]

Done.

+   *     user has confirmed the dialog before. This ensures that the user is
+   *     presented with the dialog only once. If left |undefined|, the dialog
    *     will pop up every time the user attempts to set |pref| to |true|.
    * @extends {options.SettingsDialog}
    */
   function ConfirmDialog(name, title, pageDivName, okButton, cancelButton, pref,
-                         metric, confirmed_pref) {
+                         metric, opt_confirmed_pref) {
     SettingsDialog.call(this, name, title, pageDivName, okButton, cancelButton);
     this.pref = pref;
     this.metric = metric;
-    this.confirmed_pref = confirmed_pref;
+    this.confirmed_pref = opt_confirmed_pref;

[Dan Beam, 2014/09/11 02:53:09]

nit: this.confirmed_pref -> this.confirmedPref_

[Vitaly Pavlenko, 2014/09/11 04:16:25]

Done.

     this.confirmed_ = false;
   }