Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1400)

Unified Diff: chrome/browser/resources/options/inline_editable_list.js

Issue 553573003: Compile chrome://settings, part 3: 167 proper errors left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@G_options_errors_1
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/inline_editable_list.js
diff --git a/chrome/browser/resources/options/inline_editable_list.js b/chrome/browser/resources/options/inline_editable_list.js
index cc6c9f7c3e1d9052a6a98c48d24b6f3fd7fe92dc..89d10e7309592acb2871034315782d7fcaef7e6f 100644
--- a/chrome/browser/resources/options/inline_editable_list.js
+++ b/chrome/browser/resources/options/inline_editable_list.js
@@ -236,8 +236,9 @@ cr.define('options', function() {
* @private
*/
createEditableTextCell: function(text) {
- var container = this.ownerDocument.createElement('div');
- var textEl;
+ var container = /** @type {HTMLElement} */(
+ this.ownerDocument.createElement('div'));
+ var textEl = null;
if (!this.isPlaceholder) {
textEl = this.ownerDocument.createElement('div');
textEl.className = 'static-text';
@@ -406,6 +407,10 @@ cr.define('options', function() {
}
handleWindowBlurs();
+ /**
+ * @constructor
+ * @extends {options.DeletableItemList}
+ */
var InlineEditableItemList = cr.ui.define('list');
InlineEditableItemList.prototype = {
« no previous file with comments | « chrome/browser/resources/options/deletable_item_list.js ('k') | chrome/browser/resources/options/options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698