Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: chrome/browser/resources/options/deletable_item_list.js

Issue 553573003: Compile chrome://settings, part 3: 167 proper errors left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@G_options_errors_1
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/deletable_item_list.js
diff --git a/chrome/browser/resources/options/deletable_item_list.js b/chrome/browser/resources/options/deletable_item_list.js
index 465fde71546f006688f0c630bb6dc09f7f660a5f..33ca307f894604065c08c3e79b01d6f7ca56ad56 100644
--- a/chrome/browser/resources/options/deletable_item_list.js
+++ b/chrome/browser/resources/options/deletable_item_list.js
@@ -44,10 +44,12 @@ cr.define('options', function() {
this.classList.add('deletable-item');
- this.contentElement_ = this.ownerDocument.createElement('div');
+ this.contentElement_ = /** @type {HTMLElement} */(
+ this.ownerDocument.createElement('div'));
this.appendChild(this.contentElement_);
- this.closeButtonElement_ = this.ownerDocument.createElement('button');
+ this.closeButtonElement_ = /** @type {HTMLElement} */(
+ this.ownerDocument.createElement('button'));
this.closeButtonElement_.className =
'raw-button row-delete-button custom-appearance';
this.closeButtonElement_.addEventListener('mousedown',
@@ -123,6 +125,10 @@ cr.define('options', function() {
},
};
+ /**
+ * @constructor
+ * @extends {cr.ui.List}
+ */
var DeletableItemList = cr.ui.define('list');
DeletableItemList.prototype = {
@@ -131,16 +137,16 @@ cr.define('options', function() {
/** @override */
decorate: function() {
List.prototype.decorate.call(this);
- this.addEventListener('click', this.handleClick_);
+ this.addEventListener('click', this.handleClick);
this.addEventListener('keydown', this.handleKeyDown_);
},
/**
* Callback for onclick events.
* @param {Event} e The click event object.
- * @private
+ * @override
*/
- handleClick_: function(e) {
+ handleClick: function(e) {
if (this.disabled)
return;
« no previous file with comments | « chrome/browser/resources/options/confirm_dialog.js ('k') | chrome/browser/resources/options/inline_editable_list.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698