Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1591)

Issue 553543004: Update metrics verification for dev-proxy. (Closed)

Created:
6 years, 3 months ago by bolian
Modified:
6 years, 3 months ago
Reviewers:
bengr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update metrics verification for dev-proxy. Remove http://aws1.mdw.la/piatek/bypass-demo, which is not bypassed by the server now. BUG=412497 Committed: https://crrev.com/478bfc70f088fdabd3e0e2da1d399a04d4610a92 Cr-Commit-Position: refs/heads/master@{#294027} Committed: https://crrev.com/6b339cc6b4c812c198db0311f70ac3fa133b5dcf Cr-Commit-Position: refs/heads/master@{#294194}

Patch Set 1 : verification for dev proxy #

Total comments: 2

Patch Set 2 : addressed comments. #

Patch Set 3 : . #

Patch Set 4 : fixed tests #

Patch Set 5 : sync to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -17 lines) Patch
M tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py View 1 2 3 5 chunks +28 lines, -14 lines 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/bypass.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
bengr
lgtm with nit. Also, please file a bug for this and include it in the ...
6 years, 3 months ago (2014-09-09 19:11:49 UTC) #4
bolian
Thanks. Added bug. https://codereview.chromium.org/553543004/diff/40001/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right): https://codereview.chromium.org/553543004/diff/40001/tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py#newcode173 tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:173: self.effective_proxies['fallback']] On 2014/09/09 19:11:49, bengr1 wrote: ...
6 years, 3 months ago (2014-09-09 20:59:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/553543004/80001
6 years, 3 months ago (2014-09-09 21:24:01 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:80001) as 0bae38f3f8525a2b49d6df9f7152e1cc130851b1
6 years, 3 months ago (2014-09-09 23:05:50 UTC) #10
bolian
A revert of this CL (patchset #3 id:80001) has been created in https://codereview.chromium.org/559653003/ by bolian@chromium.org. ...
6 years, 3 months ago (2014-09-10 00:56:03 UTC) #11
Michael Courage
A revert of this CL (patchset #3 id:80001) has been created in https://codereview.chromium.org/555373002/ by courage@chromium.org. ...
6 years, 3 months ago (2014-09-10 00:57:10 UTC) #12
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/478bfc70f088fdabd3e0e2da1d399a04d4610a92 Cr-Commit-Position: refs/heads/master@{#294027}
6 years, 3 months ago (2014-09-10 03:56:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bolian@chromium.org/553543004/120001
6 years, 3 months ago (2014-09-10 17:24:15 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:120001) as f3aaec7e6861594bec4bb0a11e4c44fc97b4e9aa
6 years, 3 months ago (2014-09-10 18:30:13 UTC) #16
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 18:37:57 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6b339cc6b4c812c198db0311f70ac3fa133b5dcf
Cr-Commit-Position: refs/heads/master@{#294194}

Powered by Google App Engine
This is Rietveld 408576698