tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py - Issue 553543004: Update metrics verification for dev-proxy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

Issue 553543004: Update metrics verification for dev-proxy. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sync to head. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

diff --git a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

index fd92a4dfabc213aef111c058c9593b719367b5db..1b38598d35b5d339970b5a19013e2075ef545db8 100644

--- a/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

+++ b/tools/chrome_proxy/integration_tests/chrome_proxy_measurements.py

@@ -183,7 +183,6 @@ class ChromeProxyHTTPFallbackProbeURL(ChromeProxyValidation):

self._metrics.AddResultsForHTTPFallback(tab, results)

-# Depends on the fix of http://crbug.com/330342.

class ChromeProxyHTTPFallbackViaHeader(ChromeProxyValidation):

"""Correctness measurement for proxy fallback.

@@ -210,7 +209,7 @@ class ChromeProxyHTTPFallbackViaHeader(ChromeProxyValidation):

_TEST_SERVER + ":80",

self._metrics.effective_proxies['fallback'],

self._metrics.effective_proxies['direct']]

- bad_proxies = [_TEST_SERVER + ":80"]

+ bad_proxies = [_TEST_SERVER + ":80", metrics.PROXY_SETTING_HTTP]

self._metrics.AddResultsForHTTPFallback(tab, results, proxies, bad_proxies)

« no previous file with comments | « no previous file | tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py » ('j') | no next file with comments »