Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 553343002: Aesthetic tweaks to sheriff-o-matic. (Closed)

Created:
6 years, 3 months ago by ojan
Modified:
6 years, 3 months ago
Reviewers:
michaelpg
CC:
blink-reviews, cbiesinger, dsinclair, jochen (gone - plz use gerrit), leviw_travelin_and_unemployed, michaelpg, szager1, teravest
Project:
blink
Visibility:
Public.

Description

Aesthetic tweaks to sheriff-o-matic. The only functional difference is that we no longer repeat the step name on every line. Otherwise, it's all CSS tweaks. NOTRY=true R=michaelpg@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181789

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix padding #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -29 lines) Patch
M Tools/GardeningServer/ui/ct-bot-failure-card.html View 1 chunk +4 lines, -0 lines 0 comments Download
M Tools/GardeningServer/ui/ct-commit.html View 1 1 chunk +11 lines, -15 lines 0 comments Download
M Tools/GardeningServer/ui/ct-commit-list.html View 1 chunk +8 lines, -1 line 0 comments Download
M Tools/GardeningServer/ui/ct-failure-stream.html View 1 chunk +1 line, -2 lines 0 comments Download
M Tools/GardeningServer/ui/ct-test-list.html View 2 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ojan
6 years, 3 months ago (2014-09-10 04:55:37 UTC) #1
michaelpg
lgtm https://codereview.chromium.org/553343002/diff/1/Tools/GardeningServer/ui/ct-commit.html File Tools/GardeningServer/ui/ct-commit.html (right): https://codereview.chromium.org/553343002/diff/1/Tools/GardeningServer/ui/ct-commit.html#newcode18 Tools/GardeningServer/ui/ct-commit.html:18: padding: 5px 5px; "padding: 5px;"
6 years, 3 months ago (2014-09-10 07:53:48 UTC) #3
ojan
https://codereview.chromium.org/553343002/diff/1/Tools/GardeningServer/ui/ct-commit.html File Tools/GardeningServer/ui/ct-commit.html (right): https://codereview.chromium.org/553343002/diff/1/Tools/GardeningServer/ui/ct-commit.html#newcode18 Tools/GardeningServer/ui/ct-commit.html:18: padding: 5px 5px; On 2014/09/10 07:53:48, michaelpg wrote: > ...
6 years, 3 months ago (2014-09-11 04:24:19 UTC) #4
ojan
6 years, 3 months ago (2014-09-11 04:25:56 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 181789 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698