Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2529)

Unified Diff: Tools/GardeningServer/ui/ct-test-list.html

Issue 553343002: Aesthetic tweaks to sheriff-o-matic. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix padding Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/GardeningServer/ui/ct-failure-stream.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/GardeningServer/ui/ct-test-list.html
diff --git a/Tools/GardeningServer/ui/ct-test-list.html b/Tools/GardeningServer/ui/ct-test-list.html
index 1406655aa376dcccb481ebcbd8d38fd5515bf5f0..7eedddb925d7df90137c079690038c28b61414b3 100644
--- a/Tools/GardeningServer/ui/ct-test-list.html
+++ b/Tools/GardeningServer/ui/ct-test-list.html
@@ -19,6 +19,10 @@ found in the LICENSE file.
min-height: 24px;
}
+ .test-failures {
+ margin-left: 15px;
+ }
+
paper-icon-button {
vertical-align: middle;
}
@@ -28,25 +32,23 @@ found in the LICENSE file.
}
</style>
<template repeat="{{ groups in testGroups_ }}">
- <!-- FIXME: Find a less redundant UI than repeating the step on each line. -->
+ <template if="{{ groups.tests.length }}">
+ <div><span style="font-weight: bold">Step:</span> {{ groups.step }}</div>
+ </template>
+
<template repeat="{{ group in groups.tests }}">
- <!-- Case 1: entire step failed -->
- <template if="{{ !group.name }}">
- <div>{{ groups.step }} <b>whole step failed</b></div>
- </template>
- <!-- Case 2: single test failure -->
+ <!-- Case 1: single test failure -->
<template if="{{ group.name && (group.tests.length == 1 || group.expanded) }}">
<template repeat="{{ test in group.tests }}">
- <div>
- {{ groups.step }}
+ <div class="test-failures">
<a href="{{ test | flakinessDashboardURL }}">{{ test.testName }}</a>
</div>
</template>
</template>
- <!-- Case 3: group of tests failed -->
+ <!-- Case 2: group of tests failed -->
<template if="{{ group.name && group.tests.length > 1 && !group.expanded }}">
- <div>
- {{ groups.step }} {{ group.name }} ({{ group.tests.length }} Tests)
+ <div class="test-failures">
+ {{ group.name }} ({{ group.tests.length }} Tests)
<paper-icon-button id="expand" icon="unfold-more" step="{{ groups.step }}" group="{{ group.name }}" on-click="{{ _expand }}"></paper-icon-button>
</div>
</template>
« no previous file with comments | « Tools/GardeningServer/ui/ct-failure-stream.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698