Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 553263004: Revert of Remove deprecated extension notification from content_settings (Closed)

Created:
6 years, 3 months ago by limasdf
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer, tapted, jam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, markusheintz_, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Remove deprecated extension notification from content_settings (patchset #6 id:240001 of https://codereview.chromium.org/276573011/) Reason for revert: Becuase this CL seems to break linux asan test http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/882 Original issue's description: > remove deprecated extension notification from content_settings. > > Use ExtensionRegistryObserver instead. > > R=bauerb@chromium.org > BUG=354046, 354458 > TEST=unit_tests > > Committed: https://crrev.com/76ad58487578183de69a8caeb48b8a22dccad652 > Cr-Commit-Position: refs/heads/master@{#294768} TBR=bauerb@chromium.org NOTREECHECKS=true NOTRY=true BUG=354046, 354458 Committed: https://crrev.com/6026661e8bd401c953bdd4c70b2099f126251aa5 Cr-Commit-Position: refs/heads/master@{#294773}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -95 lines) Patch
M chrome/browser/content_settings/content_settings_internal_extension_provider.h View 3 chunks +1 line, -16 lines 0 comments Download
M chrome/browser/content_settings/content_settings_internal_extension_provider.cc View 5 chunks +86 lines, -79 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
limasdf
Created Revert of Remove deprecated extension notification from content_settings
6 years, 3 months ago (2014-09-15 00:21:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/553263004/1
6 years, 3 months ago (2014-09-15 00:21:17 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 3 months ago (2014-09-15 00:21:18 UTC) #4
limasdf
Trent, Could you take a look?
6 years, 3 months ago (2014-09-15 00:23:05 UTC) #6
jam
this is also breaking all the debug windows bots. lgtm
6 years, 3 months ago (2014-09-15 00:57:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/553263004/1
6 years, 3 months ago (2014-09-15 00:59:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as af65d7ef4679c11609020e38b993e3c2db7abf06
6 years, 3 months ago (2014-09-15 01:04:00 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6026661e8bd401c953bdd4c70b2099f126251aa5 Cr-Commit-Position: refs/heads/master@{#294773}
6 years, 3 months ago (2014-09-15 01:06:00 UTC) #12
tapted
lgtm
6 years, 3 months ago (2014-09-15 01:19:14 UTC) #13
Bernhard Bauer
Maaaaan, shutdown is hard. :-( The good thing is, the ObserverList in ExtensionRegistry doesn't check ...
6 years, 3 months ago (2014-09-15 09:02:26 UTC) #14
limasdf
6 years, 3 months ago (2014-09-15 14:26:58 UTC) #15
Message was sent while issue was closed.
Thank you guys who taking care of this. & sorry to bother you.

I'll take a look deeply again.

Powered by Google App Engine
This is Rietveld 408576698