Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4006)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/surfaces/surface_aggregator.cc

Issue 553213003: Avoid destroying surface before the parent surface stops referencing it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/surfaces/surface.cc ('K') | « cc/surfaces/surface.cc ('k') | cc/surfaces/surface_factory.h » ('j') | cc/surfaces/surface_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_aggregator.cc
diff --git a/cc/surfaces/surface_aggregator.cc b/cc/surfaces/surface_aggregator.cc
index 050a2f0e0f3b999dcaab8c5a63b428fff4a444e0..a564c56931cd281d0ab7158a9c7a38f4ed55b8dc 100644
--- a/cc/surfaces/surface_aggregator.cc
+++ b/cc/surfaces/surface_aggregator.cc
@@ -58,7 +58,8 @@ class SurfaceAggregator::RenderPassIdAllocator {
static void UnrefHelper(base::WeakPtr<SurfaceFactory> surface_factory,
const ReturnedResourceArray& resources,
BlockingTaskRunner* main_thread_task_runner) {
- surface_factory->UnrefResources(resources);
+ if (surface_factory)
jamesr 2014/09/12 01:08:55 whoops
+ surface_factory->UnrefResources(resources);
}
RenderPassId SurfaceAggregator::RemapPassId(RenderPassId surface_local_pass_id,
« cc/surfaces/surface.cc ('K') | « cc/surfaces/surface.cc ('k') | cc/surfaces/surface_factory.h » ('j') | cc/surfaces/surface_manager.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698