cc/surfaces/surface.cc - Issue 553213003: Avoid destroying surface before the parent surface stops referencing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/surfaces/surface.cc

Issue 553213003: Avoid destroying surface before the parent surface stops referencing it. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/surfaces/surface.cc

diff --git a/cc/surfaces/surface.cc b/cc/surfaces/surface.cc

index 8f08d63d9275e9d77d6c1e0fa912b98524272237..ee7cfb282142e51db6bee50d71f77b27e45ee9dd 100644

--- a/cc/surfaces/surface.cc

+++ b/cc/surfaces/surface.cc

@@ -7,6 +7,7 @@

#include "cc/output/compositor_frame.h"

#include "cc/output/copy_output_request.h"

#include "cc/surfaces/surface_factory.h"

+#include "cc/surfaces/surface_manager.h"

namespace cc {

@@ -50,6 +51,8 @@ void Surface::QueueFrame(scoped_ptr<CompositorFrame> frame,

if (!draw_callback_.is_null())

draw_callback_.Run();

draw_callback_ = callback;

+ factory_->manager()->SatisfiesSequence(

jamesr 2014/09/12 01:08:55 the grammar here is a lil' weird. How about "DidS

+ surface_id_, &current_frame_->metadata.satisfies_sequence);

}

void Surface::RequestCopyOfOutput(scoped_ptr<CopyOutputRequest> copy_request) {

« cc/output/compositor_frame_metadata.h ('K') | « cc/output/compositor_frame_metadata.h ('k') | cc/surfaces/surface_aggregator.cc » ('j') | cc/surfaces/surface_aggregator.cc » ('J')