Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 55293003: Defer app window appearance until first paint. (Closed)

Created:
7 years, 1 month ago by mlamouri (slow - plz ping)
Modified:
7 years, 1 month ago
Reviewers:
benwells, jam
CC:
chromium-reviews, extensions-reviews_chromium.org, tfarina, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, miu+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Defer app window appearance until first paint. In order to avoid an ugly flash of white pixels when a new app window is shown, this patch defers showing a window until a non-empty backing store update has completed. The feature is behind the "enable-apps-show-on-first-paint" flag. BUG=225843, 254152 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233422

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : fix merge issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -9 lines) Patch
M apps/shell_window.h View 1 5 chunks +28 lines, -0 lines 0 comments Download
M apps/shell_window.cc View 1 2 9 chunks +60 lines, -5 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/app_window/app_window_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/public/browser/web_contents_observer.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mlamouri (slow - plz ping)
7 years, 1 month ago (2013-11-01 00:46:16 UTC) #1
benwells
lgtm
7 years, 1 month ago (2013-11-03 21:23:09 UTC) #2
mlamouri (slow - plz ping)
avi@chromium.org: Please review the three file changed under content/. Thanks :)
7 years, 1 month ago (2013-11-04 05:22:27 UTC) #3
Avi (use Gerrit)
This is content API and John likes to take these. Giving it to him. I'm ...
7 years, 1 month ago (2013-11-04 16:36:00 UTC) #4
jam
lgtm
7 years, 1 month ago (2013-11-05 18:22:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/55293003/130001
7 years, 1 month ago (2013-11-06 04:37:49 UTC) #6
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94628
7 years, 1 month ago (2013-11-06 08:49:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/55293003/130001
7 years, 1 month ago (2013-11-06 09:33:35 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94778
7 years, 1 month ago (2013-11-06 13:02:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/55293003/130001
7 years, 1 month ago (2013-11-06 22:23:17 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 00:02:34 UTC) #11
Message was sent while issue was closed. 
Change committed as 233422

Powered by Google App Engine
This is Rietveld 408576698