chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc - Issue 55293003: Defer app window appearance until first paint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc

Issue 55293003: Defer app window appearance until first paint. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix merge issue Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc

diff --git a/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc b/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc

index ea09a83ab1e831a6e06820cadca17d9a31cc6714..044ac48a0f3fab04fdb2bc4bdbd54db83794777e 100644

--- a/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc

+++ b/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc

@@ -108,13 +108,13 @@ bool AppCurrentWindowInternalClearAttentionFunction::RunWithWindow(

bool AppCurrentWindowInternalShowFunction::RunWithWindow(

ShellWindow* window) {

- window->GetBaseWindow()->Show();

+ window->Show(ShellWindow::SHOW_ACTIVE);

return true;

}

bool AppCurrentWindowInternalHideFunction::RunWithWindow(

ShellWindow* window) {

- window->GetBaseWindow()->Hide();

+ window->Hide();

return true;

}

« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/extensions/api/app_window/app_window_api.cc » ('j') | no next file with comments »