chrome/browser/resources/options/startup_overlay.js - Issue 552883002: Compile chrome://settings, part 4: 149 proper errors left

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/startup_overlay.js

Issue 552883002: Compile chrome://settings, part 4: 149 proper errors left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_2

Patch Set: fixed assert Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/settings_dialog.js ('k') | chrome/browser/ui/webui/options/search_engine_manager_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/startup_overlay.js

diff --git a/chrome/browser/resources/options/startup_overlay.js b/chrome/browser/resources/options/startup_overlay.js

index 0eb54cb90b9bd9967ec6a6c9fa10a8d69fffe0d8..4c2c523fd381b6ff6678b970fd003b77a11ea461 100644

--- a/chrome/browser/resources/options/startup_overlay.js

+++ b/chrome/browser/resources/options/startup_overlay.js

@@ -14,10 +14,10 @@ cr.define('options', function() {

function StartupOverlay() {

SettingsDialog.call(this, 'startup',

- loadTimeData.getString('startupPagesOverlayTabTitle'),

- 'startup-overlay',

- $('startup-overlay-confirm'),

- $('startup-overlay-cancel'));

+ loadTimeData.getString('startupPagesOverlayTabTitle'),

+ 'startup-overlay',

+ assertInstanceof($('startup-overlay-confirm'), HTMLButtonElement),

+ assertInstanceof($('startup-overlay-cancel'), HTMLButtonElement));

};

cr.addSingletonGetter(StartupOverlay);