chrome/browser/resources/options/settings_dialog.js - Issue 552883002: Compile chrome://settings, part 4: 149 proper errors left

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/settings_dialog.js

Issue 552883002: Compile chrome://settings, part 4: 149 proper errors left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_2

Patch Set: fixed assert Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/options/settings_dialog.js

diff --git a/chrome/browser/resources/options/settings_dialog.js b/chrome/browser/resources/options/settings_dialog.js

index 9c26c1deab554cdb88cf096d913584fea5fa8f51..01b2562de4994b934810612989e38e29032f92c2 100644

--- a/chrome/browser/resources/options/settings_dialog.js

+++ b/chrome/browser/resources/options/settings_dialog.js

@@ -17,8 +17,8 @@ cr.define('options', function() {

* @param {string} name See Page constructor.

* @param {string} title See Page constructor.

* @param {string} pageDivName See Page constructor.

- * @param {HTMLInputElement} okButton The confirmation button element.

- * @param {HTMLInputElement} cancelButton The cancellation button element.

+ * @param {HTMLButtonElement} okButton The confirmation button element.

+ * @param {HTMLButtonElement} cancelButton The cancellation button element.

* @extends {cr.ui.pageManager.Page}

function SettingsDialog(name, title, pageDivName, okButton, cancelButton) {

« no previous file with comments | « chrome/browser/resources/options/search_page.js ('k') | chrome/browser/resources/options/startup_overlay.js » ('j') | no next file with comments »