Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: tools/gn/variables.cc

Issue 552843005: Convert GN visibility to be a list. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/functions.cc ('k') | tools/gn/visibility.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/variables.cc
diff --git a/tools/gn/variables.cc b/tools/gn/variables.cc
index be758bda6f412d9397f14d74352f5c6fac15acd6..af75aef874eb97891a8ca3e5c10ae88bdc4d7f1e 100644
--- a/tools/gn/variables.cc
+++ b/tools/gn/variables.cc
@@ -823,9 +823,9 @@ const char kVisibility_HelpShort[] =
const char kVisibility_Help[] =
"visibility: A list of labels that can depend on a target.\n"
"\n"
- " A label or a list of labels and label patterns that define which\n"
- " targets can depend on the current one. These permissions are checked\n"
- " via then \"check\" command (see \"gn help check\").\n"
+ " A list of labels and label patterns that define which targets can\n"
+ " depend on the current one. These permissions are checked via the\n"
+ " \"check\" command (see \"gn help check\").\n"
"\n"
" If visibility is not defined, it defaults to public (\"*\").\n"
"\n"
@@ -848,22 +848,22 @@ const char kVisibility_Help[] =
"Examples\n"
"\n"
" Only targets in the current buildfile (\"private\", the default):\n"
- " visibility = \":*\"\n"
+ " visibility = [ \":*\" ]\n"
"\n"
" No targets (used for targets that should be leaf nodes):\n"
" visibility = []\n"
"\n"
" Any target (\"public\"):\n"
- " visibility = \"*\"\n"
+ " visibility = [ \"*\" ]\n"
"\n"
" All targets in the current directory and any subdirectory:\n"
- " visibility = \"./*\"\n"
+ " visibility = [ \"./*\" ]\n"
"\n"
" Any target in \"//bar/BUILD.gn\":\n"
- " visibility = \"//bar:*\"\n"
+ " visibility = [ \"//bar:*\" ]\n"
"\n"
" Any target in \"//bar/\" or any subdirectory thereof:\n"
- " visibility = \"//bar/*\"\n"
+ " visibility = [ \"//bar/*\"\n ]"
"\n"
" Just these specific targets:\n"
" visibility = [ \":mything\", \"//foo:something_else\" ]\n"
« no previous file with comments | « tools/gn/functions.cc ('k') | tools/gn/visibility.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698